New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Use realpath to obtain the webroot #5507

Merged
merged 1 commit into from Jun 23, 2017

Conversation

@derkostka
Contributor

derkostka commented Jun 22, 2017

Use realpath to obtain the webroot - backport of #5252
Signed-off-by: Sebastian Kostka sebastian.kostka@gmail.com

[stable12] Use realpath to obtain the webroot
Use realpath to obtain the webroot - backport
Signed-off-by: Sebastian Kostka sebastian.kostka@gmail.com
@derkostka

This comment has been minimized.

Show comment
Hide comment
@derkostka

derkostka Jun 22, 2017

Contributor

Please review @MorrisJobke

Contributor

derkostka commented Jun 22, 2017

Please review @MorrisJobke

@MorrisJobke MorrisJobke added this to the Nextcloud 12.0.1 milestone Jun 22, 2017

@juliushaertl

This comment has been minimized.

Show comment
Hide comment
@juliushaertl

juliushaertl Jun 22, 2017

Member

@derkostka This commit needs a sign off message as well 😉

Little tip for the next time backporting, after creating a new branch from the stable branch you can use git cherry-pick [commitid] to apply the commit from the original branch.

Member

juliushaertl commented Jun 22, 2017

@derkostka This commit needs a sign off message as well 😉

Little tip for the next time backporting, after creating a new branch from the stable branch you can use git cherry-pick [commitid] to apply the commit from the original branch.

@derkostka

This comment has been minimized.

Show comment
Hide comment
@derkostka

derkostka Jun 23, 2017

Contributor

Thank you for the hint, i am just getting used to Git / Github.

There is a sign off message ? Is it at the wrong location ?

Contributor

derkostka commented Jun 23, 2017

Thank you for the hint, i am just getting used to Git / Github.

There is a sign off message ? Is it at the wrong location ?

@juliushaertl

This comment has been minimized.

Show comment
Hide comment
@juliushaertl

juliushaertl Jun 23, 2017

Member

@derkostka Ah I missed that, I guess CI complains because you forgot to wrap your email in < >

Member

juliushaertl commented Jun 23, 2017

@derkostka Ah I missed that, I guess CI complains because you forgot to wrap your email in < >

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Jun 23, 2017

Member

@derkostka Ah I missed that, I guess CI complains because you forgot to wrap your email in < >

Fine anyways ;)

Member

MorrisJobke commented Jun 23, 2017

@derkostka Ah I missed that, I guess CI complains because you forgot to wrap your email in < >

Fine anyways ;)

@MorrisJobke MorrisJobke merged commit 8550fdf into nextcloud:stable12 Jun 23, 2017

1 check failed

continuous-integration/drone/pr the build failed
Details

@derkostka derkostka deleted the derkostka:stable12 branch Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment