New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Create users in non default backends first #5511

Merged
merged 1 commit into from Jun 22, 2017

Conversation

Projects
None yet
3 participants
@blizzz
Member

blizzz commented Jun 22, 2017

Backport of #5491

Create users in non default backends first
Most of the time, when people have multiple backends or add a
custom backend, they want to create the users there and not in
the default backend. But since that is registered first, users
were always created there.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@GitHubUser4234

👍 Thanks @blizzz !

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jun 22, 2017

Codecov Report

Merging #5511 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #5511      +/-   ##
==============================================
+ Coverage       54.14%   54.15%   +<.01%     
- Complexity      22325    22328       +3     
==============================================
  Files            1380     1380              
  Lines           85531    85538       +7     
  Branches         1329     1329              
==============================================
+ Hits            46313    46325      +12     
+ Misses          39218    39213       -5
Impacted Files Coverage Δ Complexity Δ
lib/private/User/Manager.php 85.56% <100%> (+0.54%) 74 <0> (+3) ⬆️
core/js/js.js 61.83% <0%> (+0.55%) 0% <0%> (ø) ⬇️

codecov bot commented Jun 22, 2017

Codecov Report

Merging #5511 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #5511      +/-   ##
==============================================
+ Coverage       54.14%   54.15%   +<.01%     
- Complexity      22325    22328       +3     
==============================================
  Files            1380     1380              
  Lines           85531    85538       +7     
  Branches         1329     1329              
==============================================
+ Hits            46313    46325      +12     
+ Misses          39218    39213       -5
Impacted Files Coverage Δ Complexity Δ
lib/private/User/Manager.php 85.56% <100%> (+0.54%) 74 <0> (+3) ⬆️
core/js/js.js 61.83% <0%> (+0.55%) 0% <0%> (ø) ⬇️

@nickvergessen nickvergessen merged commit 11cb699 into stable12 Jun 22, 2017

3 checks passed

codecov/patch 100% of diff hit (target 54.14%)
Details
codecov/project 54.15% (+<.01%) compared to 00256ee
Details
continuous-integration/drone/pr the build was successful
Details

@nickvergessen nickvergessen deleted the 5491-stable12 branch Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment