New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Don't create activities for email and password change before login #5521

Merged
merged 1 commit into from Jun 23, 2017

Conversation

Projects
None yet
4 participants
@nickvergessen
Member

nickvergessen commented Jun 23, 2017

Backport #5508

Don't create activities for email and password change before login
Signed-off-by: Joas Schilling <coding@schilljs.com>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jun 23, 2017

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke to be a potential reviewer.

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke to be a potential reviewer.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jun 23, 2017

Codecov Report

Merging #5521 into stable12 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #5521      +/-   ##
==============================================
- Coverage       54.15%   54.15%   -0.01%     
- Complexity      22328    22329       +1     
==============================================
  Files            1380     1380              
  Lines           85538    85539       +1     
  Branches         1329     1329              
==============================================
- Hits            46326    46321       -5     
- Misses          39212    39218       +6
Impacted Files Coverage Δ Complexity Δ
settings/Hooks.php 0% <0%> (ø) 14 <0> (+1) ⬆️
core/js/js.js 61.27% <0%> (-0.56%) 0% <0%> (ø)

codecov bot commented Jun 23, 2017

Codecov Report

Merging #5521 into stable12 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #5521      +/-   ##
==============================================
- Coverage       54.15%   54.15%   -0.01%     
- Complexity      22328    22329       +1     
==============================================
  Files            1380     1380              
  Lines           85538    85539       +1     
  Branches         1329     1329              
==============================================
- Hits            46326    46321       -5     
- Misses          39212    39218       +6
Impacted Files Coverage Δ Complexity Δ
settings/Hooks.php 0% <0%> (ø) 14 <0> (+1) ⬆️
core/js/js.js 61.27% <0%> (-0.56%) 0% <0%> (ø)
@blizzz

blizzz approved these changes Jun 23, 2017

@MorrisJobke MorrisJobke merged commit cb9a6a8 into stable12 Jun 23, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 54.15%)
Details
codecov/project 54.15% (-0.01%) compared to 70afe8d
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport-5508-no-acitivity-before-login branch Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment