New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Don't log passwords on dav exceptions #5619

Merged
merged 1 commit into from Jul 5, 2017

Conversation

Projects
None yet
3 participants
@nickvergessen
Member

nickvergessen commented Jul 5, 2017

Backport #5557

Don't log passwords on dav exceptions
Signed-off-by: Joas Schilling <coding@schilljs.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 5, 2017

Codecov Report

Merging #5619 into stable12 will decrease coverage by <.01%.
The diff coverage is 90.9%.

@@              Coverage Diff               @@
##             stable12    #5619      +/-   ##
==============================================
- Coverage       54.15%   54.14%   -0.01%     
+ Complexity      22348    22347       -1     
==============================================
  Files            1379     1379              
  Lines           85554    85545       -9     
  Branches         1329     1329              
==============================================
- Hits            46331    46321      -10     
- Misses          39223    39224       +1
Impacted Files Coverage Δ Complexity Δ
lib/private/Log.php 80% <100%> (+0.98%) 37 <0> (+1) ⬆️
.../dav/lib/Connector/Sabre/ExceptionLoggerPlugin.php 92.85% <75%> (+0.26%) 4 <0> (-2) ⬇️
.../dav/lib/Connector/Sabre/Exception/InvalidPath.php 81.81% <0%> (-18.19%) 3% <0%> (ø)
lib/private/Security/CertificateManager.php 90.81% <0%> (-1.03%) 39% <0%> (ø)
lib/private/Server.php 93.45% <0%> (+0.14%) 120% <0%> (ø) ⬇️

codecov bot commented Jul 5, 2017

Codecov Report

Merging #5619 into stable12 will decrease coverage by <.01%.
The diff coverage is 90.9%.

@@              Coverage Diff               @@
##             stable12    #5619      +/-   ##
==============================================
- Coverage       54.15%   54.14%   -0.01%     
+ Complexity      22348    22347       -1     
==============================================
  Files            1379     1379              
  Lines           85554    85545       -9     
  Branches         1329     1329              
==============================================
- Hits            46331    46321      -10     
- Misses          39223    39224       +1
Impacted Files Coverage Δ Complexity Δ
lib/private/Log.php 80% <100%> (+0.98%) 37 <0> (+1) ⬆️
.../dav/lib/Connector/Sabre/ExceptionLoggerPlugin.php 92.85% <75%> (+0.26%) 4 <0> (-2) ⬇️
.../dav/lib/Connector/Sabre/Exception/InvalidPath.php 81.81% <0%> (-18.19%) 3% <0%> (ø)
lib/private/Security/CertificateManager.php 90.81% <0%> (-1.03%) 39% <0%> (ø)
lib/private/Server.php 93.45% <0%> (+0.14%) 120% <0%> (ø) ⬇️
@blizzz

blizzz approved these changes Jul 5, 2017

@blizzz blizzz merged commit 40e4540 into stable12 Jul 5, 2017

3 checks passed

codecov/patch 90.9% of diff hit (target 54.15%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +36.75% compared to 5f0932a
Details
continuous-integration/drone/pr the build was successful
Details

@blizzz blizzz deleted the backport-5557-dont-log-passwords-on-dav-exceptions-either branch Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment