New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Use PNG icons for activity emails and ios client #5648

Merged
merged 3 commits into from Jul 7, 2017

Conversation

Projects
None yet
3 participants
@nickvergessen
Member

nickvergessen commented Jul 7, 2017

Backport #5483

nickvergessen added some commits Jun 20, 2017

Add a flag to allow checking if SVGs are okay
Signed-off-by: Joas Schilling <coding@schilljs.com>
Use PNG version of the icons for shipped activities
Signed-off-by: Joas Schilling <coding@schilljs.com>
Fix tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke

Tested and works 👍

@daita

This comment has been minimized.

Show comment
Hide comment
@daita

daita Jul 7, 2017

Member

This was yesterday on master
selection_033


This is today on stable12
selection_032

Member

daita commented Jul 7, 2017

This was yesterday on master
selection_033


This is today on stable12
selection_032

@daita

This comment has been minimized.

Show comment
Hide comment
@daita

daita Jul 7, 2017

Member

looks like an issue with the webmail client, original mail on the server contains the right img src=""

Member

daita commented Jul 7, 2017

looks like an issue with the webmail client, original mail on the server contains the right img src=""

@daita

daita approved these changes Jul 7, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 7, 2017

Codecov Report

Merging #5648 into stable12 will decrease coverage by 0.13%.
The diff coverage is 4.71%.

@@              Coverage Diff               @@
##             stable12    #5648      +/-   ##
==============================================
- Coverage       54.19%   54.05%   -0.14%     
- Complexity      22358    22442      +84     
==============================================
  Files            1379     1379              
  Lines           85556    85769     +213     
  Branches         1329     1329              
==============================================
+ Hits            46363    46365       +2     
- Misses          39193    39404     +211
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Activity/Providers/RemoteShares.php 0% <0%> (ø) 17 <0> (+2) ⬆️
...files_sharing/lib/Activity/Providers/Downloads.php 0% <0%> (ø) 17 <0> (+2) ⬆️
...pps/files_sharing/lib/Activity/Providers/Users.php 0% <0%> (ø) 23 <0> (+2) ⬆️
apps/dav/lib/CalDAV/Activity/Provider/Todo.php 0% <0%> (ø) 25 <0> (+1) ⬆️
apps/files/lib/Activity/FavoriteProvider.php 0% <0%> (ø) 18 <0> (+4) ⬆️
apps/files/lib/Activity/Provider.php 13.69% <0%> (-3.85%) 71 <0> (+16)
apps/systemtags/lib/Activity/Provider.php 0% <0%> (ø) 41 <0> (+2) ⬆️
apps/sharebymail/lib/Activity.php 0% <0%> (ø) 39 <0> (+8) ⬆️
...ps/files_sharing/lib/Activity/Providers/Groups.php 0% <0%> (ø) 17 <0> (+2) ⬆️
apps/comments/lib/Activity/Provider.php 5.82% <0%> (-0.18%) 22 <0> (+1)
... and 11 more

codecov bot commented Jul 7, 2017

Codecov Report

Merging #5648 into stable12 will decrease coverage by 0.13%.
The diff coverage is 4.71%.

@@              Coverage Diff               @@
##             stable12    #5648      +/-   ##
==============================================
- Coverage       54.19%   54.05%   -0.14%     
- Complexity      22358    22442      +84     
==============================================
  Files            1379     1379              
  Lines           85556    85769     +213     
  Branches         1329     1329              
==============================================
+ Hits            46363    46365       +2     
- Misses          39193    39404     +211
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Activity/Providers/RemoteShares.php 0% <0%> (ø) 17 <0> (+2) ⬆️
...files_sharing/lib/Activity/Providers/Downloads.php 0% <0%> (ø) 17 <0> (+2) ⬆️
...pps/files_sharing/lib/Activity/Providers/Users.php 0% <0%> (ø) 23 <0> (+2) ⬆️
apps/dav/lib/CalDAV/Activity/Provider/Todo.php 0% <0%> (ø) 25 <0> (+1) ⬆️
apps/files/lib/Activity/FavoriteProvider.php 0% <0%> (ø) 18 <0> (+4) ⬆️
apps/files/lib/Activity/Provider.php 13.69% <0%> (-3.85%) 71 <0> (+16)
apps/systemtags/lib/Activity/Provider.php 0% <0%> (ø) 41 <0> (+2) ⬆️
apps/sharebymail/lib/Activity.php 0% <0%> (ø) 39 <0> (+8) ⬆️
...ps/files_sharing/lib/Activity/Providers/Groups.php 0% <0%> (ø) 17 <0> (+2) ⬆️
apps/comments/lib/Activity/Provider.php 5.82% <0%> (-0.18%) 22 <0> (+1)
... and 11 more

@MorrisJobke MorrisJobke merged commit a5182ab into stable12 Jul 7, 2017

1 of 3 checks passed

codecov/patch 4.71% of diff hit (target 54.19%)
Details
codecov/project 54.05% (-0.14%) compared to 36e3f3c
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport-5483-png-files-for-activity-emails branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment