New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Fix unselecting items on multi select dropdowns #5679

Merged
merged 5 commits into from Jul 11, 2017

Conversation

@danxuliu
Member

danxuliu commented Jul 11, 2017

Backport of #5656

danxuliu added some commits Jul 8, 2017

Fix typo
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Extract app navigation elements to its own context
The app navigation is not exclusive to the Files app but a generic
component used by other apps too, so its locators and steps should be in
its own context.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Add acceptance tests for unselecting items in dropdown for tags
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Add select2-toggleselect to the JavaScript files to load
"select2-toggleselect.js" provides an extension to Select2 that makes
possible to unselect items in a multi-select dropdown by clicking on
them. It seems that its load slipped through when moving things around
in commit 6a470e5; this commit adds it
to the JavaScript files to be loaded in the same position that it should
have had in that commit (based on how the other declarations were
moved).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Enable the toggleSelect extension in multi-select dropdowns
The toggleSelect extension for Select2 makes possible to unselect items
in a multi-select dropdown by clicking on them; this behaviour should be
enabled in all the multi-select dropdowns used in the server.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit e768426 into stable12 Jul 11, 2017

1 of 2 checks passed

continuous-integration/drone/push the build failed
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the stable12-5656-fix-unselecting-items-on-multi-select-dropdowns branch Jul 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment