New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12] properly block file upload to non-active filelist #5692

Merged
merged 3 commits into from Jul 13, 2017

Conversation

Projects
None yet
4 participants
@icewind1991
Member

icewind1991 commented Jul 12, 2017

Backport of #5672

icewind1991 added some commits Jul 10, 2017

properly block file upload to non-active filelist
Signed-off-by: Robin Appelman <robin@icewind.nl>
fix test
Signed-off-by: Robin Appelman <robin@icewind.nl>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 12, 2017

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @ChristophWurst and @MorrisJobke to be potential reviewers.

mention-bot commented Jul 12, 2017

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @ChristophWurst and @MorrisJobke to be potential reviewers.

@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke requested a review from nickvergessen Jul 12, 2017

@nickvergessen

Works, but maybe we could also get rid of the blue hover color in the future.

Fix autoloader
Signed-off-by: Morris Jobke <hey@morrisjobke.de>

@MorrisJobke MorrisJobke merged commit 701a865 into stable12 Jul 13, 2017

1 check was pending

continuous-integration/drone/pr this build is pending
Details

@MorrisJobke MorrisJobke deleted the upload-hidden-filelist-12 branch Jul 13, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 13, 2017

Codecov Report

Merging #5692 into stable12 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #5692      +/-   ##
==============================================
+ Coverage       54.09%   54.09%   +<.01%     
  Complexity      22413    22413              
==============================================
  Files            1379     1379              
  Lines           85719    85719              
  Branches         1329     1329              
==============================================
+ Hits            46368    46370       +2     
+ Misses          39351    39349       -2
Impacted Files Coverage Δ Complexity Δ
core/js/js.js 61.94% <0%> (+0.11%) 0% <0%> (ø) ⬇️
lib/private/Server.php 93.45% <0%> (+0.14%) 120% <0%> (ø) ⬇️

codecov bot commented Jul 13, 2017

Codecov Report

Merging #5692 into stable12 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #5692      +/-   ##
==============================================
+ Coverage       54.09%   54.09%   +<.01%     
  Complexity      22413    22413              
==============================================
  Files            1379     1379              
  Lines           85719    85719              
  Branches         1329     1329              
==============================================
+ Hits            46368    46370       +2     
+ Misses          39351    39349       -2
Impacted Files Coverage Δ Complexity Δ
core/js/js.js 61.94% <0%> (+0.11%) 0% <0%> (ø) ⬇️
lib/private/Server.php 93.45% <0%> (+0.14%) 120% <0%> (ø) ⬇️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment