New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12] null users dont exist #5711

Merged
merged 1 commit into from Jul 14, 2017

Conversation

Projects
None yet
3 participants
@icewind1991
Member

icewind1991 commented Jul 13, 2017

Backport of #5709

@icewind1991 icewind1991 added this to the Nextcloud 12.0.1 milestone Jul 13, 2017

@icewind1991 icewind1991 requested review from adsworth and nickvergessen Jul 13, 2017

null users dont exist
Signed-off-by: Robin Appelman <robin@icewind.nl>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 13, 2017

Codecov Report

Merging #5711 into stable12 will increase coverage by 0.03%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #5711      +/-   ##
==============================================
+ Coverage       54.09%   54.12%   +0.03%     
- Complexity      22413    22436      +23     
==============================================
  Files            1379     1380       +1     
  Lines           85730    85815      +85     
  Branches         1329     1329              
==============================================
+ Hits            46378    46450      +72     
- Misses          39352    39365      +13
Impacted Files Coverage Δ Complexity Δ
lib/private/User/Manager.php 85.71% <100%> (+0.14%) 77 <0> (+3) ⬆️
lib/private/User/Database.php 72% <0%> (-1.6%) 44% <0%> (ø)
core/js/js.js 61.27% <0%> (-0.56%) 0% <0%> (ø)
lib/private/Repair.php 27.84% <0%> (-0.36%) 19% <0%> (ø)
lib/private/Repair/NC13/RepairInvalidPaths.php 93.75% <0%> (ø) 19% <0%> (?)
lib/private/Files/Cache/Wrapper/CacheJail.php 88.09% <0%> (+0.29%) 38% <0%> (+1%) ⬆️

codecov bot commented Jul 13, 2017

Codecov Report

Merging #5711 into stable12 will increase coverage by 0.03%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #5711      +/-   ##
==============================================
+ Coverage       54.09%   54.12%   +0.03%     
- Complexity      22413    22436      +23     
==============================================
  Files            1379     1380       +1     
  Lines           85730    85815      +85     
  Branches         1329     1329              
==============================================
+ Hits            46378    46450      +72     
- Misses          39352    39365      +13
Impacted Files Coverage Δ Complexity Δ
lib/private/User/Manager.php 85.71% <100%> (+0.14%) 77 <0> (+3) ⬆️
lib/private/User/Database.php 72% <0%> (-1.6%) 44% <0%> (ø)
core/js/js.js 61.27% <0%> (-0.56%) 0% <0%> (ø)
lib/private/Repair.php 27.84% <0%> (-0.36%) 19% <0%> (ø)
lib/private/Repair/NC13/RepairInvalidPaths.php 93.75% <0%> (ø) 19% <0%> (?)
lib/private/Files/Cache/Wrapper/CacheJail.php 88.09% <0%> (+0.29%) 38% <0%> (+1%) ⬆️
@MorrisJobke

👍

@blizzz

blizzz approved these changes Jul 14, 2017

@blizzz blizzz merged commit b9d7c48 into stable12 Jul 14, 2017

3 checks passed

codecov/patch 100% of diff hit (target 54.09%)
Details
codecov/project 54.12% (+0.03%) compared to 61bac56
Details
continuous-integration/drone/pr the build was successful
Details

@blizzz blizzz deleted the null-user-exist-12 branch Jul 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment