New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Show warning if PHP 7.2 is used #5793

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
3 participants
@LukasReschke
Member

LukasReschke commented Jul 19, 2017

Ref Ref #5791

@LukasReschke LukasReschke added this to the Nextcloud 11.0.4 milestone Jul 19, 2017

Show warning if PHP 7.2 is used
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 21, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (stable11@53d5c0f). Click here to learn what that means.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             stable11    #5793   +/-   ##
===========================================
  Coverage            ?   57.41%           
  Complexity          ?    19458           
===========================================
  Files               ?     1215           
  Lines               ?    72677           
  Branches            ?     1239           
===========================================
  Hits                ?    41725           
  Misses              ?    30952           
  Partials            ?        0
Impacted Files Coverage Δ Complexity Δ
index.php 0% <0%> (ø) 0 <0> (?)

codecov bot commented Jul 21, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (stable11@53d5c0f). Click here to learn what that means.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             stable11    #5793   +/-   ##
===========================================
  Coverage            ?   57.41%           
  Complexity          ?    19458           
===========================================
  Files               ?     1215           
  Lines               ?    72677           
  Branches            ?     1239           
===========================================
  Hits                ?    41725           
  Misses              ?    30952           
  Partials            ?        0
Impacted Files Coverage Δ Complexity Δ
index.php 0% <0%> (ø) 0 <0> (?)
@MorrisJobke

I added the same check to the console.php and tested it 👍

@rullzer rullzer merged commit b8d673c into stable11 Jul 21, 2017

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@rullzer rullzer deleted the stable11-prevent-php7.2-usage branch Jul 21, 2017

saper added a commit to saper/documentation-1 that referenced this pull request Dec 5, 2017

saper added a commit to saper/documentation-1 that referenced this pull request Dec 6, 2017

MorrisJobke added a commit to nextcloud/documentation that referenced this pull request Dec 8, 2017

MorrisJobke added a commit to nextcloud/documentation that referenced this pull request Dec 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment