New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a repair step to drop the account_terms table on oc migration #5902

Merged
merged 3 commits into from Jul 27, 2017

Conversation

Projects
None yet
4 participants
@nickvergessen
Member

nickvergessen commented Jul 27, 2017

Abusing the backport label for a forward port to master.

Add a repair step to drop the account_terms table on oc migration
Signed-off-by: Joas Schilling <coding@schilljs.com>
This is RC3
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Jul 27, 2017

Member

Fixed the updater itself, it held a copy of the array...

Member

nickvergessen commented Jul 27, 2017

Fixed the updater itself, it held a copy of the array...

@jospoortvliet

This comment has been minimized.

Show comment
Hide comment
@jospoortvliet

jospoortvliet Jul 27, 2017

Member

testing in progress...

Member

jospoortvliet commented Jul 27, 2017

testing in progress...

Use the existing array of OC versions
Signed-off-by: Joas Schilling <coding@schilljs.com>
@jospoortvliet

This comment has been minimized.

Show comment
Hide comment
@jospoortvliet

jospoortvliet Jul 27, 2017

Member

Tested, works here. Go for it 👍

Member

jospoortvliet commented Jul 27, 2017

Tested, works here. Go for it 👍

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Jul 27, 2017

Member

Tested, works here. Go for it 👍

Waiting for CI.

Member

MorrisJobke commented Jul 27, 2017

Tested, works here. Go for it 👍

Waiting for CI.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 27, 2017

Codecov Report

Merging #5902 into stable12 will increase coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #5902      +/-   ##
==============================================
+ Coverage       54.08%   54.08%   +<.01%     
- Complexity      22449    22453       +4     
==============================================
  Files            1381     1382       +1     
  Lines           85858    85867       +9     
  Branches         1328     1328              
==============================================
+ Hits            46438    46444       +6     
- Misses          39420    39423       +3
Impacted Files Coverage Δ Complexity Δ
.../private/Repair/Owncloud/DropAccountTermsTable.php 0% <0%> (ø) 4 <4> (?)
version.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Repair.php 27.5% <0%> (-0.35%) 19 <0> (ø)
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
lib/private/Updater.php 6.25% <0%> (+0.04%) 77% <0%> (ø) ⬇️
lib/private/Server.php 93.81% <0%> (+0.14%) 121% <0%> (ø) ⬇️
apps/files_external/lib/Lib/Storage/SMB.php 51.32% <0%> (+0.37%) 116% <0%> (ø) ⬇️
core/js/js.js 61.83% <0%> (+0.55%) 0% <0%> (ø) ⬇️

codecov bot commented Jul 27, 2017

Codecov Report

Merging #5902 into stable12 will increase coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #5902      +/-   ##
==============================================
+ Coverage       54.08%   54.08%   +<.01%     
- Complexity      22449    22453       +4     
==============================================
  Files            1381     1382       +1     
  Lines           85858    85867       +9     
  Branches         1328     1328              
==============================================
+ Hits            46438    46444       +6     
- Misses          39420    39423       +3
Impacted Files Coverage Δ Complexity Δ
.../private/Repair/Owncloud/DropAccountTermsTable.php 0% <0%> (ø) 4 <4> (?)
version.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Repair.php 27.5% <0%> (-0.35%) 19 <0> (ø)
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
lib/private/Updater.php 6.25% <0%> (+0.04%) 77% <0%> (ø) ⬇️
lib/private/Server.php 93.81% <0%> (+0.14%) 121% <0%> (ø) ⬇️
apps/files_external/lib/Lib/Storage/SMB.php 51.32% <0%> (+0.37%) 116% <0%> (ø) ⬇️
core/js/js.js 61.83% <0%> (+0.55%) 0% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit 2476a5f into stable12 Jul 27, 2017

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the oc-migration branch Jul 27, 2017

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Aug 4, 2017

Member

@nickvergessen 🏓 backport pending

Member

MorrisJobke commented Aug 4, 2017

@nickvergessen 🏓 backport pending

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Aug 4, 2017

Member

I will do the FORWARD port on monday

Member

nickvergessen commented Aug 4, 2017

I will do the FORWARD port on monday

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Aug 4, 2017

Member

I will do the FORWARD port on monday

You and your backport-requests that are already backports :P

Member

MorrisJobke commented Aug 4, 2017

I will do the FORWARD port on monday

You and your backport-requests that are already backports :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment