New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brackets around concat statements so comparing the result works a… #5919

Merged
merged 1 commit into from Jul 28, 2017

Conversation

@nickvergessen
Member

nickvergessen commented Jul 28, 2017

Fix #5909

Needs forward port to master

Add brackets around concat statements so comparing the result works a…
…s intended

Signed-off-by: Joas Schilling <coding@schilljs.com>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 28, 2017

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991 to be a potential reviewer.

mention-bot commented Jul 28, 2017

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991 to be a potential reviewer.

@daita

daita approved these changes Jul 28, 2017

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Jul 28, 2017

Member

@nickvergessen Could you open the backport? Thanks

Member

MorrisJobke commented Jul 28, 2017

@nickvergessen Could you open the backport? Thanks

@LukasReschke LukasReschke merged commit 7425316 into stable12 Jul 28, 2017

1 check failed

continuous-integration/drone/pr the build failed
Details

@LukasReschke LukasReschke deleted the add-brackets-on-concat-method branch Jul 28, 2017

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Jul 28, 2017

Member

Forward port at #5922

Member

LukasReschke commented Jul 28, 2017

Forward port at #5922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment