New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9] Prevent setting email and triggering events at login time (#25531) #594

Merged
merged 1 commit into from Aug 1, 2016

Conversation

Projects
None yet
5 participants
@schiessle
Member

schiessle commented Jul 27, 2016

backport of #592

Whenever an LDAP user also has an email address defined in LDAP, the
LDAP code will try and update the email address of the locally known
user. This happens at login time or every time the user's LDAP
attributes are processed.

There is code listening to the email setting hook which updates the
system address book, which also will trigger FS setup due to avatars
and other things.

This fix only sets the email address when really necessary.

Prevent setting email and triggering events at login time (#25531)
Whenever an LDAP user also has an email address defined in LDAP, the
LDAP code will try and update the email address of the locally known
user. This happens at login time or every time the user's LDAP
attributes are processed.

There is code listening to the email setting hook which updates the
system address book, which also will trigger FS setup due to avatars
and other things.

This fix only sets the email address when really necessary.
@icewind1991

This comment has been minimized.

Show comment
Hide comment
@icewind1991
Member

icewind1991 commented Jul 27, 2016

👍

@schiessle

This comment has been minimized.

Show comment
Hide comment
@schiessle

schiessle Jul 29, 2016

Member

@blizzz mind having a look at this LDAP pr? Thanks!

Member

schiessle commented Jul 29, 2016

@blizzz mind having a look at this LDAP pr? Thanks!

@blizzz

This comment has been minimized.

Show comment
Hide comment
@blizzz

blizzz Jul 31, 2016

Member

LGTM

Member

blizzz commented Jul 31, 2016

LGTM

@MorrisJobke MorrisJobke merged commit 76d7612 into stable9 Aug 1, 2016

3 checks passed

Scrutinizer 1 updated code elements
Details
approvals/lgtm this commit looks good
continuous-integration/drone the build was successful
Details

@MorrisJobke MorrisJobke deleted the ldap-avoidneedlesssetemailonlogin-stable9 branch Aug 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment