Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the accounts table exists #6097

Merged
merged 3 commits into from Aug 14, 2017

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @LukasReschke and @owncloud-bot to be potential reviewers.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member

I updated the autoloader. 😉

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 14, 2017
@codecov
Copy link

codecov bot commented Aug 14, 2017

Codecov Report

Merging #6097 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #6097      +/-   ##
============================================
- Coverage     53.13%   53.12%   -0.02%     
- Complexity    22798    22802       +4     
============================================
  Files          1406     1407       +1     
  Lines         88220    88237      +17     
  Branches       1327     1327              
============================================
- Hits          46874    46873       -1     
- Misses        41346    41364      +18
Impacted Files Coverage Δ Complexity Δ
core/Migrations/Version13000Date20170718121200.php 0% <ø> (ø) 32 <0> (ø) ⬇️
version.php 0% <0%> (ø) 0 <0> (ø) ⬇️
core/Migrations/Version13000Date20170814074715.php 0% <0%> (ø) 4 <4> (?)
apps/comments/lib/EventHandler.php 79.16% <0%> (-8.34%) 7% <0%> (ø)
lib/private/Server.php 84.55% <0%> (-0.13%) 121% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.77% <0%> (+0.24%) 136% <0%> (ø) ⬇️
lib/private/Security/CertificateManager.php 92.07% <0%> (+0.99%) 39% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit 95b7fa3 into master Aug 14, 2017
@MorrisJobke MorrisJobke deleted the issue-6078-accounts-table-missing branch August 14, 2017 10:14
@tcitworld
Copy link
Member

Didn't fixed it for me. Sad. :(

@jancborchardt
Copy link
Member

Same here actually, still have the same problem. cc @nickvergessen

@nickvergessen
Copy link
Member Author

Yeah well find out what actually deletes this table for you guys. Maybe some app or something...

The migration here will only fix it once, then it knows it ran and the table should already exist.....

@pellaeon
Copy link
Contributor

I'm also hitting this issue, even the migration was run:

sqlite> SELECT * FROM oc_migrations;
core|13000Date20170705121758
core|13000Date20170718121200
core|13000Date20170814074715
twofactor_backupcodes|1002Date20170607104347
twofactor_backupcodes|1002Date20170607113030

@nickvergessen
Copy link
Member Author

There was an issue with sqlite, which was fixed for 12.0.3:
#6406 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: install and update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants