fix: Correctly detect appid for dist css files#61100
Merged
Merged
Conversation
Follow-up of ab551c4 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
Altahrim,
ArtificialOwl,
leftybournes and
salmart-dev
and removed request for
a team
susnux
approved these changes
Jun 9, 2026
Contributor
|
/backport to stable34 |
Contributor
|
/backport to stable33 |
This comment was marked as outdated.
This comment was marked as outdated.
… the polyfill I’m not sure why psalm cannot see we have a polyfill for array_last. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
artonge
approved these changes
Jun 9, 2026
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up of ab551c4
This avoids the error "Only lowercase alphanumeric characters are allowed in appIds; check paths of installed app [1 characters replaced]" in the logs, because it was trying to use "user_status-menu.css" as an appid.
Checklist
3. to review, feature component)stable32)AI (if applicable)