New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9] libxml - compare against loaded version #629

Merged
merged 1 commit into from Jul 28, 2016

Conversation

Projects
None yet
3 participants
@MorrisJobke
Member

MorrisJobke commented Jul 28, 2016

  • if the compiled in version is older than the loaded version Nextcloud doesn't work
  • uses the loaded libxml version to check against
  • backport of #612

fixes #205

@kasi45 @nickvergessen @LukasReschke @rullzer Please review :)

libxml - compare against loaded version
* if the compiled in version is older than the loaded version Nextcloud doesn't work
* uses the loaded libxml version to check against

fixes #205

@MorrisJobke MorrisJobke added this to the Nextcloud 9.0.54 milestone Jul 28, 2016

$errors[] = array(
'error' => $l->t('libxml2 2.7.0 is at least required. Currently %s is installed.', [LIBXML_DOTTED_VERSION]),
'error' => $l->t('libxml2 2.7.0 is at least required. Currently %s is installed.', [$major . '.' . $minor . '.' . $patch]),

This comment has been minimized.

@rullzer

rullzer Jul 28, 2016

Member

... currently loaded

@rullzer

rullzer Jul 28, 2016

Member

... currently loaded

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Jul 28, 2016

Member

LGTM

Member

rullzer commented Jul 28, 2016

LGTM

1 similar comment
@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke
Member

LukasReschke commented Jul 28, 2016

LGTM

@MorrisJobke MorrisJobke merged commit fe2ca83 into stable9 Jul 28, 2016

4 checks passed

Scrutinizer No new issues
Details
approvals/lgtm this commit looks good
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MorrisJobke MorrisJobke deleted the stable9-backport-612 branch Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment