New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Allow to close sidebar for text files #6525

Merged
merged 1 commit into from Sep 20, 2017

Conversation

Projects
None yet
3 participants
@MorrisJobke
Member

MorrisJobke commented Sep 15, 2017

backport of #6499

Tested and works here 馃憤

Allow to close sidebar for text files
* the close button was overlapped by the text preview and you could not close the sidebar then

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 15, 2017

Codecov Report

Merging #6525 into stable12 will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #6525      +/-   ##
==============================================
- Coverage       53.77%   53.77%   -0.01%     
  Complexity      22527    22527              
==============================================
  Files            1383     1383              
  Lines           86498    86498              
  Branches         1328     1328              
==============================================
- Hits            46517    46515       -2     
- Misses          39981    39983       +2
Impacted Files Coverage 螖 Complexity 螖
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (酶)
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (酶)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (酶)
lib/private/Server.php 84.8% <0%> (+0.12%) 121% <0%> (酶) 猬囷笍

codecov bot commented Sep 15, 2017

Codecov Report

Merging #6525 into stable12 will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #6525      +/-   ##
==============================================
- Coverage       53.77%   53.77%   -0.01%     
  Complexity      22527    22527              
==============================================
  Files            1383     1383              
  Lines           86498    86498              
  Branches         1328     1328              
==============================================
- Hits            46517    46515       -2     
- Misses          39981    39983       +2
Impacted Files Coverage 螖 Complexity 螖
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (酶)
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (酶)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (酶)
lib/private/Server.php 84.8% <0%> (+0.12%) 121% <0%> (酶) 猬囷笍
@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Sep 18, 2017

Member

Works, however if the text in the first line is long, the X will overlay the text and is not discoverable anymore.
bildschirmfoto vom 2017-09-18 13-25-50

Member

nickvergessen commented Sep 18, 2017

Works, however if the text in the first line is long, the X will overlay the text and is not discoverable anymore.
bildschirmfoto vom 2017-09-18 13-25-50

@MorrisJobke MorrisJobke merged commit aa58633 into stable12 Sep 20, 2017

2 of 3 checks passed

codecov/project 53.77% (-0.01%) compared to 51c110d
Details
codecov/patch Coverage not affected when comparing 51c110d...efec52e
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 12-6499 branch Sep 20, 2017

@MorrisJobke MorrisJobke referenced this pull request Nov 20, 2017

Merged

12.0.4 RC #7225

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment