New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] throw 101 when an empty group string is provided #6548

Merged
merged 1 commit into from Sep 20, 2017

Conversation

Projects
None yet
5 participants
@blizzz
Member

blizzz commented Sep 18, 2017

No description provided.

throw 101 when an empty group string is provided
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

@blizzz blizzz added this to the Nextcloud 11.0.6 milestone Sep 18, 2017

@blizzz blizzz requested review from rullzer and nickvergessen Sep 18, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 18, 2017

@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @LukasReschke and @nickvergessen to be potential reviewers.

mention-bot commented Sep 18, 2017

@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @LukasReschke and @nickvergessen to be potential reviewers.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 18, 2017

Codecov Report

Merging #6548 into stable11 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable11    #6548      +/-   ##
==============================================
+ Coverage       57.43%   57.43%   +<.01%     
- Complexity      19471    19472       +1     
==============================================
  Files            1215     1215              
  Lines           72706    72706              
  Branches         1239     1239              
==============================================
+ Hits            41757    41759       +2     
+ Misses          30949    30947       -2
Impacted Files Coverage Δ Complexity Δ
...rovisioning_api/lib/Controller/UsersController.php 82.87% <100%> (ø) 96 <0> (+1) ⬆️
lib/private/Security/CertificateManager.php 92.78% <0%> (-1.04%) 38% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 73.93% <0%> (-0.26%) 129% <0%> (ø)
apps/comments/lib/EventHandler.php 100% <0%> (ø) 7% <0%> (ø) ⬇️
lib/private/Server.php 92.74% <0%> (+0.16%) 119% <0%> (ø) ⬇️
lib/private/Files/Storage/DAV.php 7.32% <0%> (+0.23%) 159% <0%> (ø) ⬇️
apps/dav/lib/CalDAV/PublicCalendar.php 100% <0%> (+7.14%) 10% <0%> (ø) ⬇️

codecov bot commented Sep 18, 2017

Codecov Report

Merging #6548 into stable11 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable11    #6548      +/-   ##
==============================================
+ Coverage       57.43%   57.43%   +<.01%     
- Complexity      19471    19472       +1     
==============================================
  Files            1215     1215              
  Lines           72706    72706              
  Branches         1239     1239              
==============================================
+ Hits            41757    41759       +2     
+ Misses          30949    30947       -2
Impacted Files Coverage Δ Complexity Δ
...rovisioning_api/lib/Controller/UsersController.php 82.87% <100%> (ø) 96 <0> (+1) ⬆️
lib/private/Security/CertificateManager.php 92.78% <0%> (-1.04%) 38% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 73.93% <0%> (-0.26%) 129% <0%> (ø)
apps/comments/lib/EventHandler.php 100% <0%> (ø) 7% <0%> (ø) ⬇️
lib/private/Server.php 92.74% <0%> (+0.16%) 119% <0%> (ø) ⬇️
lib/private/Files/Storage/DAV.php 7.32% <0%> (+0.23%) 159% <0%> (ø) ⬇️
apps/dav/lib/CalDAV/PublicCalendar.php 100% <0%> (+7.14%) 10% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit 706907c into stable11 Sep 20, 2017

3 checks passed

codecov/patch 100% of diff hit (target 57.43%)
Details
codecov/project 57.43% (+<.01%) compared to 377dd14
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport-6545-stable11 branch Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment