New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable12] contacts menu privacy #6554

Merged
merged 8 commits into from Sep 27, 2017

Conversation

Projects
None yet
5 participants
@LukasReschke
Member

LukasReschke commented Sep 18, 2017

Backport of #5585 to stable12

LEDfan and others added some commits Jul 2, 2017

Privacy enhancements for contacts menu
 - Groups, which are excluded from sharing should not see local users at all
 - If sharing is restricted to users own groups, he should only see contacts from his groups:

Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
Fix tests
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
Add tests
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
Some code improvements
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
Improve code style
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
Fix issue when disabling the shareapi_only_share_with_group_members o…
…ption + fix findOne

Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
Add filter for `shareapi_allow_share_dialog_user_enumeration`
This adjusts the contacts menu to also support searching by email address which is relevant in scenarios where no UID is known such as LDAP, etc.

Furthermore, if `shareapi_allow_share_dialog_user_enumeration` is disabled only results are shown that match the full user ID or email address.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@danxuliu

This comment has been minimized.

Show comment
Hide comment
@danxuliu

danxuliu Sep 21, 2017

Member

#6609 also applies here.

Member

danxuliu commented Sep 21, 2017

#6609 also applies here.

@rullzer rullzer requested review from MorrisJobke and ChristophWurst Sep 24, 2017

@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit f6ccc1e into stable12 Sep 27, 2017

1 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the stable12-contacts_menu_privacy branch Sep 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment