expose local and locking memcaches trough public interfaces #6571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
reviewed
Sep 19, 2017
lib/public/ICacheFactory.php
Outdated
| * create a distributed cache instance | ||
| * | ||
| * @param string $prefix | ||
| * @return \OC\Memcache\Cache |
MorrisJobke
reviewed
Sep 19, 2017
lib/public/ICacheFactory.php
Outdated
| * create a local cache instance | ||
| * | ||
| * @param string $prefix | ||
| * @return \OC\Memcache\Cache |
icewind1991
force-pushed
the
cachefactory-local-locking
branch
from
c85e114
to
1183eb2
Compare
Codecov Report
@@ Coverage Diff @@
## master #6571 +/- ##
===========================================
- Coverage 53.06% 52.86% -0.2%
- Complexity 22552 22560 +8
===========================================
Files 1414 1413 -1
Lines 87741 88079 +338
Branches 1340 1340
===========================================
+ Hits 46561 46565 +4
- Misses 41180 41514 +334
|
MorrisJobke
approved these changes
Sep 19, 2017
| @@ -31,7 +31,7 @@ | |||
| */ | |||
| interface ICacheFactory{ | |||
| /** | |||
| * Get a memory cache instance | |||
| * Get a distributed memory cache instance | |||
There was a problem hiding this comment.
Since we now have a dedicated method to get a distributed cache, would it make sense to deprecate this ambiguous method and remove it in the future?
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
cachefactory-local-locking
branch
from
1183eb2
to
388376c
Compare
ChristophWurst
approved these changes
Sep 20, 2017
ChristophWurst
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give apps access to the different caches.
Using the local instead of distributed cache where applicable can lower response times and improve scalability