New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color-border variable #6649

Merged
merged 1 commit into from Sep 26, 2017

Conversation

@skjnldsv
Member

skjnldsv commented Sep 26, 2017

After #6372 we have a variable that future apps may need (to avoid fallback 馃槃 )
I think this should be backported. What do you think? @MorrisJobke @karlitschek

Add color-border variable
Signed-off-by: John Molakvo忙 (skjnldsv) <skjnldsv@protonmail.com>

@skjnldsv skjnldsv added the design label Sep 26, 2017

@skjnldsv skjnldsv added this to the Nextcloud 12.0.4 milestone Sep 26, 2017

@skjnldsv skjnldsv self-assigned this Sep 26, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 26, 2017

Codecov Report

Merging #6649 into stable12 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #6649      +/-   ##
==============================================
+ Coverage       53.75%   53.76%   +<.01%     
  Complexity      22541    22541              
==============================================
  Files            1383     1383              
  Lines           86539    86539              
  Branches         1328     1328              
==============================================
+ Hits            46523    46528       +5     
+ Misses          40016    40011       -5
Impacted Files Coverage 螖 Complexity 螖
core/js/js.js 61.83% <0%> (+0.55%) 0% <0%> (酶) 猬囷笍

codecov bot commented Sep 26, 2017

Codecov Report

Merging #6649 into stable12 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #6649      +/-   ##
==============================================
+ Coverage       53.75%   53.76%   +<.01%     
  Complexity      22541    22541              
==============================================
  Files            1383     1383              
  Lines           86539    86539              
  Branches         1328     1328              
==============================================
+ Hits            46523    46528       +5     
+ Misses          40016    40011       -5
Impacted Files Coverage 螖 Complexity 螖
core/js/js.js 61.83% <0%> (+0.55%) 0% <0%> (酶) 猬囷笍
@jancborchardt

Looks good! Should we also directly add the border-radius variable for 3px?

@skjnldsv

This comment has been minimized.

Show comment
Hide comment
@skjnldsv

skjnldsv Sep 26, 2017

Member

@jancborchardt Mind to do that on master and add the box shadow too? :)

Member

skjnldsv commented Sep 26, 2017

@jancborchardt Mind to do that on master and add the box shadow too? :)

@karlitschek

This comment has been minimized.

Show comment
Hide comment
@karlitschek

karlitschek Sep 26, 2017

Member

backporting shouldn鈥檛 hurt I guess

Member

karlitschek commented Sep 26, 2017

backporting shouldn鈥檛 hurt I guess

@MorrisJobke MorrisJobke merged commit 98da784 into stable12 Sep 26, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 0f39ea5...e9c3c4f
Details
codecov/project 53.76% (+<.01%) compared to 0f39ea5
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the color-border-variable branch Sep 26, 2017

@MorrisJobke MorrisJobke referenced this pull request Nov 20, 2017

Merged

12.0.4 RC #7225

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment