New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not stop on scss compilation failure #6661

Merged
merged 1 commit into from Sep 27, 2017

Conversation

@skjnldsv
Member

skjnldsv commented Sep 27, 2017

Backport of #6647

Do not stop on scss compilation failure
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 27, 2017

Codecov Report

Merging #6661 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #6661      +/-   ##
==============================================
+ Coverage       53.76%   53.76%   +<.01%     
  Complexity      22541    22541              
==============================================
  Files            1383     1383              
  Lines           86539    86540       +1     
  Branches         1328     1328              
==============================================
+ Hits            46527    46528       +1     
  Misses          40012    40012
Impacted Files Coverage Δ Complexity Δ
lib/private/Template/SCSSCacher.php 69.59% <100%> (+0.24%) 35 <0> (ø) ⬇️

codecov bot commented Sep 27, 2017

Codecov Report

Merging #6661 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #6661      +/-   ##
==============================================
+ Coverage       53.76%   53.76%   +<.01%     
  Complexity      22541    22541              
==============================================
  Files            1383     1383              
  Lines           86539    86540       +1     
  Branches         1328     1328              
==============================================
+ Hits            46527    46528       +1     
  Misses          40012    40012
Impacted Files Coverage Δ Complexity Δ
lib/private/Template/SCSSCacher.php 69.59% <100%> (+0.24%) 35 <0> (ø) ⬇️

@skjnldsv skjnldsv merged commit 898fb16 into stable12 Sep 27, 2017

3 checks passed

codecov/patch 100% of diff hit (target 53.76%)
Details
codecov/project 53.76% (+<.01%) compared to af92360
Details
continuous-integration/drone/pr the build was successful
Details

@skjnldsv skjnldsv deleted the no-take-only-throw branch Sep 27, 2017

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Sep 27, 2017

Member

@skjnldsv Please always wait for 2 approvals ;)

Member

MorrisJobke commented Sep 27, 2017

@skjnldsv Please always wait for 2 approvals ;)

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Sep 27, 2017

Member

👍 from me

Member

MorrisJobke commented Sep 27, 2017

👍 from me

@skjnldsv

This comment has been minimized.

Show comment
Hide comment
@skjnldsv

skjnldsv Sep 27, 2017

Member

@MorrisJobke There was mine as well! 😆
More seriously, my bad, I usually wait for 2-3! :)

Member

skjnldsv commented Sep 27, 2017

@MorrisJobke There was mine as well! 😆
More seriously, my bad, I usually wait for 2-3! :)

@MorrisJobke MorrisJobke referenced this pull request Nov 20, 2017

Merged

12.0.4 RC #7225

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment