New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP3 without cover don't get a preview #6695

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
4 participants
@rullzer
Member

rullzer commented Sep 28, 2017

Backport of #3794

As 11 is also affected.

MP3 without cover don't get a preview
* Fixes #2739

It tries to create an image from an SVG file. Which we don't support. So
this fails and prints an log line. Then we fall back anyways to the 404
and fetch the default icon.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@nickvergessen nickvergessen merged commit 6f6d8cc into stable11 Sep 29, 2017

1 check failed

continuous-integration/drone/pr the build failed
Details

@nickvergessen nickvergessen deleted the 11_3794 branch Sep 29, 2017

@puntorosso

This comment has been minimized.

Show comment
Hide comment
@puntorosso

puntorosso Nov 18, 2017

Still showing this icon when the mp3 doesn't have an artwork

screen shot 2017-11-18 at 14 15 24

There is some workaround? A fallback to a default image would also be a nice solution.

puntorosso commented Nov 18, 2017

Still showing this icon when the mp3 doesn't have an artwork

screen shot 2017-11-18 at 14 15 24

There is some workaround? A fallback to a default image would also be a nice solution.

@puntorosso

This comment has been minimized.

Show comment
Hide comment
@puntorosso

puntorosso Apr 29, 2018

Hi, any news on this?
Still showing the missing icon in 13.0.2

puntorosso commented Apr 29, 2018

Hi, any news on this?
Still showing the missing icon in 13.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment