New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] fix LDAP User deletion (cleanup), fixes #3365 #6699

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
4 participants
@blizzz
Member

blizzz commented Sep 29, 2017

Backport of #6522

@nextcloud/ldap

Backport of #6522
fix LDAP User deletion (cleanup)

discovered a bug in the integration test which lead to following a
different code path and giving a false-positive  success feedback.

Also listens now to the evendispatcher instead of old hook system

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

@blizzz blizzz added this to the Nextcloud 12.0.4 milestone Sep 29, 2017

@MorrisJobke MorrisJobke changed the title from [stable] fix LDAP User deletion (cleanup), fixes #3365 to [stable12] fix LDAP User deletion (cleanup), fixes #3365 Sep 29, 2017

@blizzz blizzz added the Hacktoberfest label Oct 5, 2017

@rullzer

rullzer approved these changes Oct 5, 2017

@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 70e2072 into stable12 Nov 7, 2017

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the backport-6522-stable12 branch Nov 7, 2017

@MorrisJobke MorrisJobke referenced this pull request Nov 20, 2017

Merged

12.0.4 RC #7225

1 of 1 task complete
@nitrag

This comment has been minimized.

Show comment
Hide comment
@nitrag

nitrag Aug 18, 2018

I have an issue with this. Is this also deleting the user if the LDAP server is inaccessible (credentials are incorrect)?

I changed the password for my bind user, not remembering to change the password in Nextcloud, and now my (thankfully only in testing right not production) user is gone, including the files. When I fixed the credentials, it created a new user.

nitrag commented Aug 18, 2018

I have an issue with this. Is this also deleting the user if the LDAP server is inaccessible (credentials are incorrect)?

I changed the password for my bind user, not remembering to change the password in Nextcloud, and now my (thankfully only in testing right not production) user is gone, including the files. When I fixed the credentials, it created a new user.

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Aug 20, 2018

Member

I have an issue with this. Is this also deleting the user if the LDAP server is inaccessible (credentials are incorrect)?

No.

I changed the password for my bind user, not remembering to change the password in Nextcloud, and now my (thankfully only in testing right not production) user is gone, including the files. When I fixed the credentials, it created a new user.

Another issue then.

Member

MorrisJobke commented Aug 20, 2018

I have an issue with this. Is this also deleting the user if the LDAP server is inaccessible (credentials are incorrect)?

No.

I changed the password for my bind user, not remembering to change the password in Nextcloud, and now my (thankfully only in testing right not production) user is gone, including the files. When I fixed the credentials, it created a new user.

Another issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment