New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contacts menu for IE11 #6795

Merged
merged 1 commit into from Oct 12, 2017

Conversation

@ChristophWurst
Member

ChristophWurst commented Oct 9, 2017

IE11 triggers an 'input' event whenever an input is focussed
or loses focus. Thus this causes an endless loading loop as soon
as the view is re-rendered. To prevent this, this remembers the
previous search term and ignores events where the term has not
changed.

Fixes #5281

Tested with IE11 on Win10 and FF58 (nightly) on Linux.

Fix contacts menu for IE11
IE11 triggers an 'input' event whenever an input is focussed
or loses focus. Thus this causes an endless loading loop as soon
as the view is re-rendered. To prevent this, this remembers the
previous search term and ignores events where the term has not
changed.

Fixes #5281

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@codecov

This comment has been minimized.

codecov bot commented Oct 9, 2017

Codecov Report

Merging #6795 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #6795      +/-   ##
============================================
- Coverage     52.99%   52.99%   -0.01%     
  Complexity    22657    22657              
============================================
  Files          1430     1430              
  Lines         88070    88073       +3     
  Branches       1343     1344       +1     
============================================
- Hits          46677    46675       -2     
- Misses        41393    41398       +5
Impacted Files Coverage Δ Complexity Δ
core/js/contactsmenu.js 90% <0%> (-1.98%) 0 <0> (ø)
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
@rullzer

This comment has been minimized.

Member

rullzer commented Oct 10, 2017

Nice stuff!
Should probably be backported ;)

@blizzz

blizzz approved these changes Oct 12, 2017

no IE at hand, code looks good

@blizzz blizzz merged commit af4810d into master Oct 12, 2017

2 of 4 checks passed

codecov/patch 0% of diff hit (target 52.99%)
Details
codecov/project 52.99% (-0.01%) compared to 5304598
Details
Scrutinizer 1 new issues
Details
continuous-integration/drone/pr the build was successful
Details

@blizzz blizzz deleted the fix/contactsmenu-ie11 branch Oct 12, 2017

@blizzz

This comment has been minimized.

Member

blizzz commented Oct 12, 2017

@ChristophWurst you do the backporting?

@ChristophWurst

This comment has been minimized.

Member

ChristophWurst commented Oct 12, 2017

@ChristophWurst you do the backporting?

Sure: #6823

@ChristophWurst ChristophWurst moved this from TO REVIEW (max 4 PRs) to DONE in Christoph's Tasks Oct 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment