New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Don't add a LIKE condition when it's not needed #6945

Merged
merged 1 commit into from Oct 25, 2017

Conversation

@MorrisJobke
Member

MorrisJobke commented Oct 24, 2017

Backport of #6633

Code looks good 馃憤

Don't add a LIKE condition when it's not needed
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 25, 2017

Codecov Report

Merging #6945 into stable12 will decrease coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #6945      +/-   ##
==============================================
- Coverage       53.76%   53.76%   -0.01%     
- Complexity      22577    22578       +1     
==============================================
  Files            1384     1384              
  Lines           86622    86623       +1     
  Branches         1329     1329              
==============================================
  Hits            46569    46569              
- Misses          40053    40054       +1
Impacted Files Coverage 螖 Complexity 螖
apps/dav/lib/CardDAV/CardDavBackend.php 85.56% <100%> (+0.03%) 89 <0> (+1) 猬嗭笍
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (酶)

codecov bot commented Oct 25, 2017

Codecov Report

Merging #6945 into stable12 will decrease coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #6945      +/-   ##
==============================================
- Coverage       53.76%   53.76%   -0.01%     
- Complexity      22577    22578       +1     
==============================================
  Files            1384     1384              
  Lines           86622    86623       +1     
  Branches         1329     1329              
==============================================
  Hits            46569    46569              
- Misses          40053    40054       +1
Impacted Files Coverage 螖 Complexity 螖
apps/dav/lib/CardDAV/CardDavBackend.php 85.56% <100%> (+0.03%) 89 <0> (+1) 猬嗭笍
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (酶)
@ChristophWurst

Makes sense

@rullzer rullzer merged commit 27e8352 into stable12 Oct 25, 2017

3 checks passed

codecov/patch 100% of diff hit (target 53.76%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +46.23% compared to 895336a
Details
continuous-integration/drone/pr the build was successful
Details

@rullzer rullzer deleted the 12-6633 branch Oct 25, 2017

@MorrisJobke MorrisJobke referenced this pull request Nov 20, 2017

Merged

12.0.4 RC #7225

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment