New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatch method signature in Nextcloud 11 #7023

Merged
merged 1 commit into from Nov 2, 2017

Conversation

Projects
None yet
3 participants
@aimakun

aimakun commented Oct 31, 2017

Refer to issue #6991, I included fixes for other child class related to \OC\Files\Storage\Common also.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 31, 2017

Codecov Report

Merging #7023 into stable11 will increase coverage by <.01%.
The diff coverage is 66.66%.

@@              Coverage Diff               @@
##             stable11    #7023      +/-   ##
==============================================
+ Coverage       57.48%   57.49%   +<.01%     
  Complexity      19508    19508              
==============================================
  Files            1220     1220              
  Lines           72828    72828              
  Branches         1239     1239              
==============================================
+ Hits            41868    41869       +1     
+ Misses          30960    30959       -1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/FailedStorage.php 3.4% <0%> (ø) 44 <1> (ø) ⬇️
lib/private/Lockdown/Filesystem/NullStorage.php 100% <100%> (ø) 40 <1> (ø) ⬇️
lib/private/Files/Storage/Local.php 83.41% <100%> (ø) 85 <2> (ø) ⬇️
lib/private/Files/Storage/Common.php 80.35% <0%> (+0.35%) 129% <0%> (ø) ⬇️

codecov bot commented Oct 31, 2017

Codecov Report

Merging #7023 into stable11 will increase coverage by <.01%.
The diff coverage is 66.66%.

@@              Coverage Diff               @@
##             stable11    #7023      +/-   ##
==============================================
+ Coverage       57.48%   57.49%   +<.01%     
  Complexity      19508    19508              
==============================================
  Files            1220     1220              
  Lines           72828    72828              
  Branches         1239     1239              
==============================================
+ Hits            41868    41869       +1     
+ Misses          30960    30959       -1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/FailedStorage.php 3.4% <0%> (ø) 44 <1> (ø) ⬇️
lib/private/Lockdown/Filesystem/NullStorage.php 100% <100%> (ø) 40 <1> (ø) ⬇️
lib/private/Files/Storage/Local.php 83.41% <100%> (ø) 85 <2> (ø) ⬇️
lib/private/Files/Storage/Common.php 80.35% <0%> (+0.35%) 129% <0%> (ø) ⬇️
@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Oct 31, 2017

Member

Can you please sign your commits? See https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md#sign-your-work for more information.

You can do this manually for now:

git commit --amend -s
git push --force origin <your branch>
Member

nickvergessen commented Oct 31, 2017

Can you please sign your commits? See https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md#sign-your-work for more information.

You can do this manually for now:

git commit --amend -s
git push --force origin <your branch>
@aimakun

This comment has been minimized.

Show comment
Hide comment
@aimakun

aimakun Oct 31, 2017

I’ll do it today.

aimakun commented Oct 31, 2017

I’ll do it today.

Issue #6991: Fix mismatch copyFromStorage method signature between \O…
…C\Files\Storage\Common and its child classes

Signed-off-by: Teerapong Kraiamornchai <aima.kun@gmail.com>
@rullzer

rullzer approved these changes Nov 2, 2017

@rullzer rullzer merged commit 3bf915a into nextcloud:stable11 Nov 2, 2017

3 checks passed

codecov/patch 66.66% of diff hit (target 57.48%)
Details
codecov/project 57.49% (+<.01%) compared to 08a7a9e
Details
continuous-integration/drone/pr the build was successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment