New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Better readability for text on log in page which is directly on backgrounds #7028

Merged
merged 1 commit into from Oct 31, 2017

Conversation

@jancborchardt
Member

jancborchardt commented Oct 31, 2017

Backport of #7026

Please review @nextcloud/designers @irgendwie @rullzer :)

Better readability for text on log in page which is directly on backg…
…rounds

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

@jancborchardt jancborchardt added this to the Nextcloud 12.0.5 milestone Oct 31, 2017

@jancborchardt jancborchardt self-assigned this Oct 31, 2017

@jancborchardt jancborchardt requested review from rullzer and irgendwie Oct 31, 2017

@jancborchardt jancborchardt changed the title from [stable12] Better readability for text on log in page which is directly on backgr to [stable12] Better readability for text on log in page which is directly on backgrounds Oct 31, 2017

@jancborchardt jancborchardt requested a review from MariusBluem Oct 31, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 31, 2017

Codecov Report

Merging #7028 into stable12 will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #7028      +/-   ##
==============================================
- Coverage       53.75%   53.75%   -0.01%     
  Complexity      22579    22579              
==============================================
  Files            1384     1384              
  Lines           86624    86628       +4     
  Branches         1329     1329              
==============================================
+ Hits            46569    46570       +1     
- Misses          40055    40058       +3
Impacted Files Coverage Δ Complexity Δ
version.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️

codecov bot commented Oct 31, 2017

Codecov Report

Merging #7028 into stable12 will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #7028      +/-   ##
==============================================
- Coverage       53.75%   53.75%   -0.01%     
  Complexity      22579    22579              
==============================================
  Files            1384     1384              
  Lines           86624    86628       +4     
  Branches         1329     1329              
==============================================
+ Hits            46569    46570       +1     
- Misses          40055    40058       +3
Impacted Files Coverage Δ Complexity Δ
version.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️
@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Oct 31, 2017

Member

Merging as it’s CSS and that is not covered by tests anywy.

Member

jancborchardt commented Oct 31, 2017

Merging as it’s CSS and that is not covered by tests anywy.

@jancborchardt jancborchardt merged commit 2bf0c70 into stable12 Oct 31, 2017

3 of 4 checks passed

codecov/project 53.75% (-0.01%) compared to 00ffed5
Details
codecov/patch Coverage not affected when comparing 00ffed5...1f280bd
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@jancborchardt jancborchardt deleted the stable12-login-readability branch Oct 31, 2017

@MorrisJobke MorrisJobke referenced this pull request Nov 20, 2017

Merged

12.0.4 RC #7225

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment