New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Improve mimetype detection for object storages #7081

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
2 participants
@MorrisJobke
Member

MorrisJobke commented Nov 6, 2017

Backport of #6958

Tested and works fine here 馃憤

Improve mimetype detection for object storages
Object storage instances always fall back to the content based mimetype detection, because the file name for object storage was always random due to the fact that it was temporarily storage in a generated temp file. This patch adds a check before that to make sure to use the original file name for this purpose and also remove possible other extensions like the versioning or part file extension.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

@MorrisJobke MorrisJobke added this to the Nextcloud 12.0.4 milestone Nov 6, 2017

@MorrisJobke MorrisJobke requested review from rullzer, icewind1991 and schiessle Nov 6, 2017

@rullzer

rullzer approved these changes Nov 6, 2017

馃悩

@MorrisJobke MorrisJobke merged commit 8a8e765 into stable12 Nov 6, 2017

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the 12-6958 branch Nov 6, 2017

@MorrisJobke MorrisJobke referenced this pull request Nov 20, 2017

Merged

12.0.4 RC #7225

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment