New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] ensure uid for calendar objects is unique #7096

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@georgehrke
Member

georgehrke commented Nov 7, 2017

backport of #7042

ensure uid for calendar objects is unique
Signed-off-by: Georg Ehrke <developer@georgehrke.com>

@georgehrke georgehrke requested review from MorrisJobke and LukasReschke Nov 7, 2017

@MorrisJobke MorrisJobke added this to the Nextcloud 12.0.4 milestone Nov 7, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 7, 2017

Codecov Report

Merging #7096 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #7096      +/-   ##
==============================================
+ Coverage       53.75%   53.75%   +<.01%     
- Complexity      22587    22588       +1     
==============================================
  Files            1384     1384              
  Lines           86644    86654      +10     
  Branches         1329     1329              
==============================================
+ Hits            46574    46584      +10     
  Misses          40070    40070
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/CalDavBackend.php 85.71% <100%> (+0.15%) 219 <0> (+1) ⬆️

codecov bot commented Nov 7, 2017

Codecov Report

Merging #7096 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #7096      +/-   ##
==============================================
+ Coverage       53.75%   53.75%   +<.01%     
- Complexity      22587    22588       +1     
==============================================
  Files            1384     1384              
  Lines           86644    86654      +10     
  Branches         1329     1329              
==============================================
+ Hits            46574    46584      +10     
  Misses          40070    40070
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/CalDavBackend.php 85.71% <100%> (+0.15%) 219 <0> (+1) ⬆️
@MorrisJobke

Tested and works 👍

@LukasReschke LukasReschke merged commit 4d117a5 into stable12 Nov 7, 2017

3 checks passed

codecov/patch 100% of diff hit (target 53.75%)
Details
codecov/project 53.75% (+<.01%) compared to 0756fc0
Details
continuous-integration/drone/pr the build was successful
Details

@LukasReschke LukasReschke deleted the backport-stable12-7042 branch Nov 7, 2017

@MorrisJobke MorrisJobke referenced this pull request Nov 20, 2017

Merged

12.0.4 RC #7225

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment