New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Improve performance of UserMountCache with external storage folders #7120

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
3 participants
@MorrisJobke
Member

MorrisJobke commented Nov 9, 2017

Backport of #6988

Improve performance of UserMountCache with external storage folders
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 9, 2017

Codecov Report

Merging #7120 into stable12 will decrease coverage by 2.8%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #7120      +/-   ##
==============================================
- Coverage       56.55%   53.74%   -2.81%     
- Complexity      21053    22588    +1535     
==============================================
  Files            1289     1384      +95     
  Lines           79449    86685    +7236     
  Branches         1329     1329              
==============================================
+ Hits            44935    46593    +1658     
- Misses          34514    40092    +5578
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Config/UserMountCache.php 89.36% <100%> (+0.23%) 41 <0> (+1) ⬆️
apps/sharebymail/tests/SettingsTest.php 52.17% <0%> (-47.83%) 3% <0%> (ø)
lib/private/Security/RateLimiting/Limiter.php 55.55% <0%> (-44.45%) 5% <0%> (ø)
settings/Controller/EncryptionController.php 56% <0%> (-37.34%) 8% <0%> (ø)
settings/Controller/GroupsController.php 64.61% <0%> (-35.39%) 9% <0%> (ø)
lib/public/API.php 66.66% <0%> (-33.34%) 1% <0%> (ø)
...ps/comments/tests/Unit/AppInfo/ApplicationTest.php 69.56% <0%> (-30.44%) 4% <0%> (ø)
apps/user_ldap/lib/Configuration.php 41.5% <0%> (-29.46%) 86% <0%> (ø)
apps/encryption/lib/Command/EnableMasterKey.php 75% <0%> (-25%) 5% <0%> (ø)
lib/private/AvatarManager.php 61.9% <0%> (-24.77%) 4% <0%> (ø)
... and 271 more

codecov bot commented Nov 9, 2017

Codecov Report

Merging #7120 into stable12 will decrease coverage by 2.8%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #7120      +/-   ##
==============================================
- Coverage       56.55%   53.74%   -2.81%     
- Complexity      21053    22588    +1535     
==============================================
  Files            1289     1384      +95     
  Lines           79449    86685    +7236     
  Branches         1329     1329              
==============================================
+ Hits            44935    46593    +1658     
- Misses          34514    40092    +5578
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Config/UserMountCache.php 89.36% <100%> (+0.23%) 41 <0> (+1) ⬆️
apps/sharebymail/tests/SettingsTest.php 52.17% <0%> (-47.83%) 3% <0%> (ø)
lib/private/Security/RateLimiting/Limiter.php 55.55% <0%> (-44.45%) 5% <0%> (ø)
settings/Controller/EncryptionController.php 56% <0%> (-37.34%) 8% <0%> (ø)
settings/Controller/GroupsController.php 64.61% <0%> (-35.39%) 9% <0%> (ø)
lib/public/API.php 66.66% <0%> (-33.34%) 1% <0%> (ø)
...ps/comments/tests/Unit/AppInfo/ApplicationTest.php 69.56% <0%> (-30.44%) 4% <0%> (ø)
apps/user_ldap/lib/Configuration.php 41.5% <0%> (-29.46%) 86% <0%> (ø)
apps/encryption/lib/Command/EnableMasterKey.php 75% <0%> (-25%) 5% <0%> (ø)
lib/private/AvatarManager.php 61.9% <0%> (-24.77%) 4% <0%> (ø)
... and 271 more
@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Nov 9, 2017

Member

Still works for me here 👍

Member

MorrisJobke commented Nov 9, 2017

Still works for me here 👍

@MorrisJobke MorrisJobke merged commit 20e5220 into stable12 Nov 9, 2017

3 checks passed

codecov/patch 100% of diff hit (target 56.55%)
Details
codecov/project Absolute coverage decreased by -2.8% but relative coverage increased by +43.44% compared to c91515c
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 12-6988 branch Nov 9, 2017

@MorrisJobke MorrisJobke referenced this pull request Nov 20, 2017

Merged

12.0.4 RC #7225

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment