New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock files even if an exception occurs (stable12) #7144

Merged
merged 1 commit into from Dec 4, 2017

Conversation

@korelstar
Member

korelstar commented Nov 11, 2017

Backport of #7014 for stable12.

Unlock files even if an exception occurs
Signed-off-by: Kristof Hamann <korelstar@users.noreply.github.com>
@codecov

This comment has been minimized.

codecov bot commented Nov 11, 2017

Codecov Report

Merging #7144 into stable12 will increase coverage by <.01%.
The diff coverage is 94.82%.

@@              Coverage Diff               @@
##             stable12    #7144      +/-   ##
==============================================
+ Coverage       53.76%   53.76%   +<.01%     
- Complexity      22587    22588       +1     
==============================================
  Files            1384     1384              
  Lines           86660    86663       +3     
  Branches         1329     1329              
==============================================
+ Hits            46591    46595       +4     
+ Misses          40069    40068       -1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/View.php 83.86% <94.82%> (+0.04%) 372 <0> (+1) ⬆️
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
lib/private/Server.php 84.8% <0%> (+0.12%) 121% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️
@korelstar

This comment has been minimized.

Member

korelstar commented Nov 22, 2017

Can we put this into 12.0.4?

@MorrisJobke

Makes sense 👍

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Nov 27, 2017

Let's wait for this merge until 12.0.4 is out

@LukasReschke

Blocking with "Request changes" so it doesn't accidentally get merged :)

12.0.4 is out

@MorrisJobke MorrisJobke merged commit 1cd5ba3 into stable12 Dec 4, 2017

3 checks passed

codecov/patch 94.82% of diff hit (target 53.76%)
Details
codecov/project 53.76% (+<.01%) compared to 097e8a4
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the rename-locks-stable12 branch Dec 4, 2017

@MorrisJobke MorrisJobke referenced this pull request Jan 8, 2018

Merged

12.0.5 RC1 #7740

13 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment