New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock files even if an exception occurs (stable11) #7148

Merged
merged 1 commit into from Nov 27, 2017

Conversation

Projects
None yet
3 participants
@korelstar
Member

korelstar commented Nov 12, 2017

Backport of #7014 for stable11.

Unlock files even if an exception occurs
Signed-off-by: Kristof Hamann <korelstar@users.noreply.github.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 12, 2017

Codecov Report

Merging #7148 into stable11 will decrease coverage by <.01%.
The diff coverage is 94.64%.

@@              Coverage Diff               @@
##             stable11    #7148      +/-   ##
==============================================
- Coverage       57.48%   57.48%   -0.01%     
- Complexity      19508    19509       +1     
==============================================
  Files            1220     1220              
  Lines           72830    72833       +3     
  Branches         1239     1239              
==============================================
+ Hits            41868    41869       +1     
- Misses          30962    30964       +2
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/View.php 85.53% <94.64%> (-0.17%) 368 <0> (+1)

codecov bot commented Nov 12, 2017

Codecov Report

Merging #7148 into stable11 will decrease coverage by <.01%.
The diff coverage is 94.64%.

@@              Coverage Diff               @@
##             stable11    #7148      +/-   ##
==============================================
- Coverage       57.48%   57.48%   -0.01%     
- Complexity      19508    19509       +1     
==============================================
  Files            1220     1220              
  Lines           72830    72833       +3     
  Branches         1239     1239              
==============================================
+ Hits            41868    41869       +1     
- Misses          30962    30964       +2
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/View.php 85.53% <94.64%> (-0.17%) 368 <0> (+1)

@korelstar korelstar added the bug label Nov 22, 2017

@korelstar

This comment has been minimized.

Show comment
Hide comment
@korelstar

korelstar Nov 22, 2017

Member

Can we put this into 11.0.6?

Member

korelstar commented Nov 22, 2017

Can we put this into 11.0.6?

@MorrisJobke MorrisJobke merged commit 3d3f9d3 into stable11 Nov 27, 2017

3 checks passed

codecov/patch 94.64% of diff hit (target 57.48%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +37.15% compared to 2e97e89
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the rename-locks-stable11 branch Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment