New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] only replace permission popupmenu #7259

Merged
merged 1 commit into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@blizzz
Member

blizzz commented Nov 23, 2017

Backport of #7211

only replace permission popupmenu
the contacts popovermenu is also present and is being replaces, ending
up in two permission popupmenus with checkboxes duplicating the id,
breaking further permission changes.

plus, fixing a selector

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 23, 2017

Codecov Report

Merging #7259 into stable12 will increase coverage by <.01%.
The diff coverage is 33.33%.

@@              Coverage Diff               @@
##             stable12    #7259      +/-   ##
==============================================
+ Coverage       53.79%   53.79%   +<.01%     
  Complexity      22590    22590              
==============================================
  Files            1384     1384              
  Lines           86666    86666              
  Branches         1329     1329              
==============================================
+ Hits            46620    46624       +4     
+ Misses          40046    40042       -4
Impacted Files Coverage Δ Complexity Δ
core/js/sharedialogshareelistview.js 44.91% <33.33%> (ø) 0 <0> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
lib/private/Server.php 84.68% <0%> (-0.13%) 121% <0%> (ø)
core/js/js.js 61.83% <0%> (+0.55%) 0% <0%> (ø) ⬇️
lib/private/Security/CertificateManager.php 92.07% <0%> (+0.99%) 39% <0%> (ø) ⬇️

codecov bot commented Nov 23, 2017

Codecov Report

Merging #7259 into stable12 will increase coverage by <.01%.
The diff coverage is 33.33%.

@@              Coverage Diff               @@
##             stable12    #7259      +/-   ##
==============================================
+ Coverage       53.79%   53.79%   +<.01%     
  Complexity      22590    22590              
==============================================
  Files            1384     1384              
  Lines           86666    86666              
  Branches         1329     1329              
==============================================
+ Hits            46620    46624       +4     
+ Misses          40046    40042       -4
Impacted Files Coverage Δ Complexity Δ
core/js/sharedialogshareelistview.js 44.91% <33.33%> (ø) 0 <0> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
lib/private/Server.php 84.68% <0%> (-0.13%) 121% <0%> (ø)
core/js/js.js 61.83% <0%> (+0.55%) 0% <0%> (ø) ⬇️
lib/private/Security/CertificateManager.php 92.07% <0%> (+0.99%) 39% <0%> (ø) ⬇️
@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 4a4cf26 into stable12 Nov 23, 2017

2 of 3 checks passed

codecov/patch 33.33% of diff hit (target 53.79%)
Details
codecov/project 53.79% (+<.01%) compared to fd46475
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 7211-stable12 branch Nov 23, 2017

@MorrisJobke MorrisJobke referenced this pull request Nov 23, 2017

Merged

Prepare 12.0.4 RC2 #7261

4 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment