New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Fix translation of federation scope menu #7353

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
4 participants
@MorrisJobke
Member

MorrisJobke commented Nov 30, 2017

  • l10n in Nextcloud works by extracting the values only passed on their location and not based on the first parameter
  • we need to change the translation pool from core to settings then
  • fixes #7345
  • backport of #7346
Fix translation of federation scope menu
* l10n in Nextcloud works by extracting the values only passed on their location and not based on the first parameter
* we need to change the translation pool from `core` to `settings` then
* fixes #7345

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Nov 30, 2017

CI failure is unrelated

@MorrisJobke MorrisJobke merged commit 18b464a into stable12 Dec 4, 2017

0 of 3 checks passed

codecov/patch CI failed.
Details
codecov/project CI failed.
Details
continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the 12-7346 branch Dec 4, 2017

@MorrisJobke MorrisJobke referenced this pull request Jan 8, 2018

Merged

12.0.5 RC1 #7740

13 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment