New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Allow to skip data dir permission checks by config #7362

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
2 participants
@MorrisJobke
Member

MorrisJobke commented Dec 1, 2017

Enables installation on services that don't allow/support permission
changes.

Tested and works 馃憤

Allow to skip data dir permission checks by config
Enables installation on services that don't allow/support permission
changes.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

@MorrisJobke MorrisJobke added this to the Nextcloud 12.0.5 milestone Dec 1, 2017

@MorrisJobke MorrisJobke requested review from rullzer, LukasReschke and blizzz Dec 1, 2017

@MorrisJobke MorrisJobke changed the title from Allow to skip data dir permission checks by config to [stable12] Allow to skip data dir permission checks by config Dec 1, 2017

@codecov

This comment has been minimized.

codecov bot commented Dec 1, 2017

Codecov Report

Merging #7362 into stable12 will decrease coverage by <.01%.
The diff coverage is 50%.

@@              Coverage Diff              @@
##             stable12   #7362      +/-   ##
=============================================
- Coverage        53.9%   53.9%   -0.01%     
- Complexity      22690   22691       +1     
=============================================
  Files            1384    1384              
  Lines           86927   86930       +3     
  Branches         1330    1330              
=============================================
+ Hits            46858   46859       +1     
- Misses          40069   40071       +2
Impacted Files Coverage 螖 Complexity 螖
config/config.sample.php 0% <0%> (酶) 0 <0> (酶) 猬囷笍
lib/private/legacy/util.php 59.79% <66.66%> (-0.04%) 226 <0> (+1)
@blizzz

blizzz approved these changes Dec 3, 2017

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Dec 4, 2017

12.0.4 is out -> merge

@MorrisJobke MorrisJobke merged commit ad08c1e into stable12 Dec 4, 2017

1 of 3 checks passed

codecov/patch 50% of diff hit (target 53.9%)
Details
codecov/project 53.9% (-0.01%) compared to 3ee749d
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 12-7347 branch Dec 4, 2017

@MorrisJobke MorrisJobke referenced this pull request Jan 8, 2018

Merged

12.0.5 RC1 #7740

13 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment