New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12]add retry wrapper when reading files from swift #7409

Merged
merged 1 commit into from Dec 8, 2017

Conversation

Projects
None yet
4 participants
@icewind1991
Member

icewind1991 commented Dec 6, 2017

Backport of #7387

add retry wrapper when reading files from swift
Signed-off-by: Robin Appelman <robin@icewind.nl>
@mention-bot

This comment has been minimized.

mention-bot commented Dec 6, 2017

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic to be a potential reviewer.

@codecov

This comment has been minimized.

codecov bot commented Dec 6, 2017

Codecov Report

Merging #7409 into stable12 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             stable12   #7409      +/-   ##
=============================================
- Coverage        53.9%   53.9%   -0.01%     
  Complexity      22692   22692              
=============================================
  Files            1384    1384              
  Lines           86933   86933              
  Branches         1330    1330              
=============================================
- Hits            46862   46857       -5     
- Misses          40071   40076       +5
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/Lib/Storage/Swift.php 0% <0%> (ø) 113 <0> (ø) ⬇️
lib/private/Files/ObjectStore/Swift.php 0% <0%> (ø) 39 <0> (ø) ⬇️
core/js/js.js 61.27% <0%> (-0.56%) 0% <0%> (ø)
@rullzer

rullzer approved these changes Dec 8, 2017

@rullzer rullzer merged commit ac29608 into stable12 Dec 8, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 53.9%)
Details
codecov/project 53.9% (-0.01%) compared to f3b9b21
Details
continuous-integration/drone/pr the build was successful
Details

@rullzer rullzer deleted the swift-retry-12 branch Dec 8, 2017

@MorrisJobke MorrisJobke referenced this pull request Jan 8, 2018

Merged

12.0.5 RC1 #7740

13 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment