New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Fix loading icon position in the app menu #7457

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
4 participants
@juliushaertl
Member

juliushaertl commented Dec 11, 2017

Backport of #7271

Before:

peek 2017-11-23 21-13

After:

peek 2017-11-23 21-14

Fix loading icon position in the app menu
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@codecov

This comment has been minimized.

codecov bot commented Dec 12, 2017

Codecov Report

Merging #7457 into stable12 will increase coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #7457      +/-   ##
==============================================
+ Coverage       53.92%   53.94%   +0.01%     
- Complexity      22701    22705       +4     
==============================================
  Files            1384     1384              
  Lines           86955    87009      +54     
  Branches         1330     1330              
==============================================
+ Hits            46889    46935      +46     
- Misses          40066    40074       +8
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 84.8% <0%> (+0.12%) 121% <0%> (ø) ⬇️
core/js/js.js 61.94% <0%> (+0.66%) 0% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 91.93% <0%> (+1.61%) 29% <0%> (ø) ⬇️
lib/private/Settings/Manager.php 50.23% <0%> (+6.05%) 48% <0%> (+4%) ⬆️

@rullzer rullzer merged commit 4b60ada into stable12 Dec 12, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 2bd2835...c023486
Details
codecov/project 53.94% (+0.01%) compared to 2bd2835
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@rullzer rullzer deleted the stable12-7271 branch Dec 12, 2017

@MorrisJobke MorrisJobke referenced this pull request Jan 8, 2018

Merged

12.0.5 RC1 #7740

13 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment