New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Fix email buttons for white theme #7558

Merged
merged 1 commit into from Dec 18, 2017

Conversation

Projects
None yet
3 participants
@MorrisJobke
Member

MorrisJobke commented Dec 18, 2017

Backport of #7427
Fixes #7557 for stable12

Fix email buttons for white theme
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Dec 18, 2017

I just tested this and it works fine 👍

/**
* Returns primary color
* @return string
* @since 13.0.0

This comment has been minimized.

@blizzz

blizzz Dec 18, 2017

Member

back to the future?

This comment has been minimized.

@MorrisJobke

MorrisJobke Dec 18, 2017

Member

Yes - but I just don't want to change it all the way - for this single time it is a bit off, but shouldn't hurt or does it? Because adding "since 12.0.5" doesn't add that much.

This comment has been minimized.

@rullzer

rullzer Dec 18, 2017

Member

Agreed. No app should really depend on it anyways as it isn't available in 12 in general.

This comment has been minimized.

@blizzz
@codecov

This comment has been minimized.

codecov bot commented Dec 18, 2017

Codecov Report

Merging #7558 into stable12 will decrease coverage by <.01%.
The diff coverage is 60%.

@@              Coverage Diff               @@
##             stable12    #7558      +/-   ##
==============================================
- Coverage       53.93%   53.93%   -0.01%     
- Complexity      22705    22708       +3     
==============================================
  Files            1385     1385              
  Lines           86978    86986       +8     
  Branches         1330     1330              
==============================================
+ Hits            46914    46916       +2     
- Misses          40064    40070       +6
Impacted Files Coverage Δ Complexity Δ
lib/public/Defaults.php 15% <0%> (-0.79%) 20 <1> (+1)
apps/theming/lib/ThemingDefaults.php 89.25% <100%> (+0.73%) 39 <2> (+1) ⬆️
lib/private/Mail/EMailTemplate.php 60.76% <100%> (+0.61%) 41 <0> (ø) ⬇️
apps/theming/lib/Capabilities.php 80% <100%> (ø) 3 <0> (-1) ⬇️
lib/private/legacy/defaults.php 41.96% <20%> (-1.03%) 47 <2> (+2)
apps/files_trashbin/lib/Expiration.php 90.32% <0%> (-1.62%) 29% <0%> (ø)

@MorrisJobke MorrisJobke merged commit 6859e5a into stable12 Dec 18, 2017

3 checks passed

codecov/patch 60% of diff hit (target 53.93%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +6.06% compared to 3a99ef5
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 12-7427 branch Dec 18, 2017

@MorrisJobke MorrisJobke referenced this pull request Jan 8, 2018

Merged

12.0.5 RC1 #7740

13 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment