New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] check userExists later, saves lookups for appData_INSTANCEID userids #7577

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
3 participants
@rullzer
Member

rullzer commented Dec 19, 2017

Backport of #7361

check userExists later, saves lookups for appData_INSTANCEID userids
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

@rullzer rullzer added this to the Nextcloud 12.0.5 milestone Dec 19, 2017

@codecov

This comment has been minimized.

codecov bot commented Dec 19, 2017

Codecov Report

Merging #7577 into stable12 will decrease coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #7577      +/-   ##
==============================================
- Coverage       53.93%   53.93%   -0.01%     
  Complexity      22708    22708              
==============================================
  Files            1385     1385              
  Lines           86987    86987              
  Branches         1330     1330              
==============================================
- Hits            46918    46917       -1     
- Misses          40069    40070       +1
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Storage.php 77.55% <100%> (ø) 32 <0> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
@rullzer

This comment has been minimized.

Member

rullzer commented Dec 19, 2017

Also 👍 from me so lets get this in

@rullzer rullzer merged commit 4ed99dd into stable12 Dec 19, 2017

3 checks passed

codecov/patch 100% of diff hit (target 53.93%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +46.06% compared to fe9f100
Details
continuous-integration/drone/pr the build was successful
Details

@rullzer rullzer deleted the 7361_12 branch Dec 19, 2017

@MorrisJobke MorrisJobke referenced this pull request Jan 8, 2018

Merged

12.0.5 RC1 #7740

13 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment