New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Fix drag shadow not visible when dragging a file on a narrow screen #7666

Merged
merged 1 commit into from Jan 9, 2018

Conversation

Projects
None yet
3 participants
@danxuliu
Member

danxuliu commented Jan 2, 2018

Backport of #7527

Fix drag shadow not visible when dragging a file on a narrow screen
When a file from the file list is dragged a drag shadow (a copy of the
file row that follows the cursor position) is created. The drag shadow
element is created as a direct child of the body element, so it needs a
higher "z-index" than the one used for the file list to be visible.

In narrow screens the "#app-content" uses a "z-index" of 1000 in order
to be visible over the "#navigation-bar" when they overlap, so the
"z-index" of the drag shadow must be at least 1000 to be visible over
the file list.

Instead of updating the hardcoded "z-index" it was removed and replaced
by CSS rules for ".dragshadow" elements to ease theming.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

@danxuliu danxuliu added this to the Nextcloud 12.0.5 milestone Jan 2, 2018

@danxuliu danxuliu requested review from rullzer and MorrisJobke Jan 2, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 2, 2018

Codecov Report

Merging #7666 into stable12 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             stable12    #7666   +/-   ##
===========================================
  Coverage       53.93%   53.93%           
  Complexity      22712    22712           
===========================================
  Files            1385     1385           
  Lines           86996    86996           
  Branches         1330     1330           
===========================================
  Hits            46919    46919           
  Misses          40077    40077
@rullzer

rullzer approved these changes Jan 5, 2018

@MorrisJobke MorrisJobke referenced this pull request Jan 8, 2018

Merged

12.0.5 RC1 #7740

13 of 13 tasks complete
@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit bbaa765 into stable12 Jan 9, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 9ed0f50...4d194b4
Details
codecov/project 53.93% remains the same compared to 9ed0f50
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the stable12-7527-fix-drag-shadow-not-visible-when-dragging-a-file-on-a-narrow-screen branch Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment