New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Do no run SyncJob in cron #7674

Merged
merged 1 commit into from Jan 9, 2018

Conversation

Projects
None yet
3 participants
@rullzer
Member

rullzer commented Jan 3, 2018

Backport of #7644

Do no run SyncJob in cron
Fixes #7184

The SyncJob can be very resource intensive. Since it requests all users
on the system to create the system addressbook. In order to do this it
creates a vcard for every user and updates the addressbook.

There is no need for this job since the proper signals are emitted and
handled in the carddav backend to update the addressbook live.

Worst comes to worst there is always the occ command to bring the
address book in sync again.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@rullzer rullzer added the 3. to review label Jan 3, 2018

@rullzer rullzer added this to the Nextcloud 12.0.5 milestone Jan 3, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 3, 2018

Codecov Report

Merging #7674 into stable12 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #7674      +/-   ##
==============================================
+ Coverage       53.93%   53.93%   +<.01%     
+ Complexity      22712    22710       -2     
==============================================
  Files            1385     1384       -1     
  Lines           86996    86990       -6     
  Branches         1330     1330              
==============================================
- Hits            46919    46918       -1     
+ Misses          40077    40072       -5
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️
@blizzz

blizzz approved these changes Jan 3, 2018

@MorrisJobke MorrisJobke referenced this pull request Jan 8, 2018

Merged

12.0.5 RC1 #7740

13 of 13 tasks complete

@MorrisJobke MorrisJobke merged commit 2f9d595 into stable12 Jan 9, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 9ed0f50...ed5f66f
Details
codecov/project 53.93% (+<.01%) compared to 9ed0f50
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 12_7644 branch Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment