New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Don't attempt to translate login names to uids when uids are provided #7694

Merged
merged 5 commits into from Jan 8, 2018

Conversation

Projects
None yet
3 participants
@blizzz
Member

blizzz commented Jan 4, 2018

Backport of #7611

blizzz added some commits Dec 22, 2017

extend tests for status quo
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
never translate login names when requiring with a user id
where appropriate, the preLoginNameUsedAsUserName hook should be thrown.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
removes invalid tests, adapts another one
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

@blizzz blizzz added this to the Nextcloud 12.0.5 milestone Jan 4, 2018

update autoloader
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@codecov

This comment has been minimized.

codecov bot commented Jan 4, 2018

Codecov Report

Merging #7694 into stable12 will decrease coverage by 23.06%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##             stable12    #7694       +/-   ##
===============================================
- Coverage       53.93%   30.86%   -23.07%     
+ Complexity      22712    22709        -3     
===============================================
  Files            1385     1385               
  Lines           86996    86994        -2     
  Branches         1330     1330               
===============================================
- Hits            46918    26851    -20067     
- Misses          40078    60143    +20065
Impacted Files Coverage Δ Complexity Δ
lib/private/User/Manager.php 26.04% <ø> (-58.81%) 74 <0> (-3)
core/Controller/LostController.php 80.53% <100%> (+0.53%) 29 <0> (ø) ⬇️
lib/public/Files/ForbiddenException.php 0% <0%> (-100%) 2% <0%> (ø)
...yBuilder/FunctionBuilder/SqliteFunctionBuilder.php 0% <0%> (-100%) 1% <0%> (ø)
lib/private/DB/QueryBuilder/QueryFunction.php 0% <0%> (-100%) 2% <0%> (ø)
...s/dav/lib/Connector/Sabre/Exception/FileLocked.php 0% <0%> (-100%) 3% <0%> (ø)
lib/private/Files/Cache/Wrapper/JailPropagator.php 0% <0%> (-100%) 1% <0%> (ø)
lib/private/Share20/Hooks.php 0% <0%> (-100%) 3% <0%> (ø)
apps/dav/lib/Connector/Sabre/Server.php 0% <0%> (-100%) 1% <0%> (ø)
apps/files_versions/lib/Command/Expire.php 0% <0%> (-100%) 3% <0%> (ø)
... and 369 more
test adoption for stable12
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

@blizzz blizzz requested review from rullzer and MorrisJobke Jan 4, 2018

@MorrisJobke MorrisJobke referenced this pull request Jan 8, 2018

Merged

12.0.5 RC1 #7740

13 of 13 tasks complete
@rullzer

rullzer approved these changes Jan 8, 2018

🐘

@rullzer rullzer merged commit 1f875ec into stable12 Jan 8, 2018

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@rullzer rullzer deleted the stable12-7611 branch Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment