New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Don't attempt to translate login names to uids when uids are provided #7695

Merged
merged 5 commits into from Jan 8, 2018

Conversation

Projects
None yet
3 participants
@blizzz
Member

blizzz commented Jan 4, 2018

Backport of #7611

blizzz added some commits Dec 22, 2017

extend tests for status quo
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
never translate login names when requiring with a user id
where appropriate, the preLoginNameUsedAsUserName hook should be thrown.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
removes invalid tests, adapts another one
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

@blizzz blizzz added this to the Nextcloud 11.0.7 milestone Jan 4, 2018

update autoloader
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@codecov

This comment has been minimized.

codecov bot commented Jan 4, 2018

Codecov Report

Merging #7695 into stable11 will decrease coverage by 24.87%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##             stable11    #7695       +/-   ##
===============================================
- Coverage       57.55%   32.67%   -24.88%     
+ Complexity      19603    19255      -348     
===============================================
  Files            1221     1214        -7     
  Lines           73007    69965     -3042     
  Branches         1241     1241               
===============================================
- Hits            42016    22864    -19152     
- Misses          30991    47101    +16110
Impacted Files Coverage Δ Complexity Δ
lib/private/User/Manager.php 25.92% <ø> (-57.51%) 63 <0> (-3)
core/Controller/LostController.php 100% <100%> (+18.26%) 25 <0> (ø) ⬇️
ocs/routes.php 0% <0%> (-100%) 0% <0%> (ø)
apps/dav/lib/CalDAV/PublicCalendarRoot.php 0% <0%> (-100%) 4% <0%> (ø)
apps/dav/lib/Connector/Sabre/Server.php 0% <0%> (-100%) 1% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFix.php 0% <0%> (-100%) 5% <0%> (ø)
lib/private/TagManager.php 0% <0%> (-100%) 4% <0%> (ø)
apps/files_sharing/lib/External/MountProvider.php 0% <0%> (-100%) 4% <0%> (ø)
...ps/comments/tests/Unit/AppInfo/ApplicationTest.php 0% <0%> (-100%) 4% <0%> (ø)
...yBuilder/FunctionBuilder/SqliteFunctionBuilder.php 0% <0%> (-100%) 1% <0%> (ø)
... and 507 more
test adoption for stable12 and stable11
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

@blizzz blizzz requested review from rullzer and MorrisJobke Jan 4, 2018

@MorrisJobke MorrisJobke referenced this pull request Jan 8, 2018

Merged

11.0.7 RC1 #7741

2 of 2 tasks complete
@rullzer

rullzer approved these changes Jan 8, 2018

🐘

@rullzer rullzer merged commit bb59107 into stable11 Jan 8, 2018

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@rullzer rullzer deleted the stable11-7694 branch Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment