New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Hide favourite icon in details view if favourite action is not available #7742

Merged
merged 1 commit into from Jan 9, 2018

Conversation

Projects
None yet
3 participants
@danxuliu
Member

danxuliu commented Jan 8, 2018

Backport of #7716

Hide favourite icon in details view if favourite action is not available
When the favourite icon in the details view is clicked the "Favorite"
action is triggered. However, if the action name given to
"triggerAction" is not found then the "Download" action is triggered
instead. As the "Favorite" action is not available in some file lists
(like "Recents") the "Download" action was executed instead in those
cases, which was a strange behaviour. Now the favourite icon is
hidden if its action is not available.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@rullzer

rullzer approved these changes Jan 8, 2018

@MorrisJobke MorrisJobke referenced this pull request Jan 8, 2018

Merged

12.0.5 RC1 #7740

13 of 13 tasks complete
@MorrisJobke

Tested and works 👍

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Jan 9, 2018

Composer failure will be fixed in #7747

@MorrisJobke MorrisJobke merged commit 2df3864 into stable12 Jan 9, 2018

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@MorrisJobke MorrisJobke deleted the stable12-7716-hide-favourite-icon-in-details-view-if-favourite-action-is-not-available branch Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment