New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Don't lie about preview types #7745

merged 2 commits into from Jan 9, 2018


None yet
4 participants

rullzer commented Jan 8, 2018

Backport of #7692

rullzer added some commits Jan 4, 2018

Don't lie about the preview mimetype
For legacy reasons we stored all the previews with a png extention.
However we did not put png data in them all the time.

This caused the preview endpoints to always report that a preview is a
png file. Which was a lie.

Since we abstract away from the storage etc in the previewmanager. There
is no need anymore to store them as .png files and instead we can use
the actual file extention.

Signed-off-by: Roeland Jago Douma <>
Only return 1 type
Throw proper exception if we can't get the mimetype for a preview. Catch
it later on so we can just return a not found for the preview.

Signed-off-by: Roeland Jago Douma <>

@rullzer rullzer added this to the Nextcloud 12.0.5 milestone Jan 8, 2018

@MorrisJobke MorrisJobke referenced this pull request Jan 8, 2018


12.0.5 RC1 #7740

13 of 13 tasks complete

This comment has been minimized.


MorrisJobke commented Jan 9, 2018

Composer is fixed in #7747

@MorrisJobke MorrisJobke merged commit db6b9fd into stable12 Jan 9, 2018

1 check failed

continuous-integration/drone/pr the build failed

@MorrisJobke MorrisJobke deleted the 7692_12 branch Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment