New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Wait for the shared link to be set in the acceptance tests #7757

Merged
merged 3 commits into from Jan 9, 2018

Conversation

Projects
None yet
4 participants
@MorrisJobke
Member

MorrisJobke commented Jan 9, 2018

Backport of #7605

danxuliu added some commits Dec 22, 2017

Fix typo in callback name
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Wait for the shared link to be set in the acceptance tests
When clicking on "Share link" in the "Sharing" tab of the Files app an
input field with the link appears. That input field already exists in
the DOM, although empty, before clicking on "Share link", and when that
is done the proper value is set and then the input field is shown.

In the acceptance tests "getValue()" can return the value of hidden
elements too, so as long as an element exists its value is returned
without waiting for the field to be visible. Due to this if the test
code runs too fast the "I write down the shared link" step could be
executed before the proper value was set, so the shared link got in that
case would be an empty value, and this would lead to failures when the
following steps were executed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Add missing timeout multiplier
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

@MorrisJobke MorrisJobke added this to the Nextcloud 12.0.5 milestone Jan 9, 2018

@MorrisJobke MorrisJobke requested review from rullzer and danxuliu Jan 9, 2018

@rullzer

rullzer approved these changes Jan 9, 2018

@MorrisJobke MorrisJobke referenced this pull request Jan 9, 2018

Merged

12.0.5 RC1 #7740

13 of 13 tasks complete
@codecov

This comment has been minimized.

codecov bot commented Jan 9, 2018

Codecov Report

Merging #7757 into stable12 will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             stable12   #7757      +/-   ##
=============================================
- Coverage        53.9%   53.9%   -0.01%     
  Complexity      22724   22724              
=============================================
  Files            1384    1384              
  Lines           87036   87036              
  Branches         1331    1331              
=============================================
- Hits            46920   46919       -1     
- Misses          40116   40117       +1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)

@MorrisJobke MorrisJobke merged commit e6f8869 into stable12 Jan 9, 2018

2 of 3 checks passed

codecov/project 53.9% (-0.01%) compared to 4c92d09
Details
codecov/patch Coverage not affected when comparing 4c92d09...fd9710b
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 12-7605 branch Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment