New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] add option to use legacy v2 auth with s3 #7758

Merged
merged 1 commit into from Jan 9, 2018

Conversation

Projects
None yet
4 participants
@MorrisJobke
Member

MorrisJobke commented Jan 9, 2018

Backport of #7570

@MorrisJobke MorrisJobke added this to the Nextcloud 12.0.5 milestone Jan 9, 2018

@MorrisJobke MorrisJobke requested review from rullzer and icewind1991 Jan 9, 2018

@mention-bot

This comment has been minimized.

mention-bot commented Jan 9, 2018

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic to be a potential reviewer.

@rullzer

rullzer approved these changes Jan 9, 2018

@MorrisJobke MorrisJobke referenced this pull request Jan 9, 2018

Merged

12.0.5 RC1 #7740

13 of 13 tasks complete
@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Jan 9, 2018

I just tested it and it still works 👍

add option to use legacy v2 auth with s3
Signed-off-by: Robin Appelman <robin@icewind.nl>
@codecov

This comment has been minimized.

codecov bot commented Jan 9, 2018

Codecov Report

Merging #7758 into stable12 will increase coverage by 1.97%.
The diff coverage is 6.54%.

@@              Coverage Diff               @@
##             stable12    #7758      +/-   ##
==============================================
+ Coverage        53.9%   55.88%   +1.97%     
+ Complexity      22724    21222    -1502     
==============================================
  Files            1384     1290      -94     
  Lines           87036    81126    -5910     
  Branches         1331     1331              
==============================================
- Hits            46920    45337    -1583     
+ Misses          40116    35789    -4327
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/ObjectStore/S3Signature.php 0% <0%> (ø) 28 <28> (?)
...ib/private/Files/ObjectStore/S3ConnectionTrait.php 68.08% <77.77%> (+10.3%) 28 <3> (+5) ⬆️
lib/private/Memcache/Memcached.php 0% <0%> (-57.9%) 31% <0%> (ø)
lib/private/Files/Storage/DAV.php 7.29% <0%> (-57.53%) 161% <0%> (ø)
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
lib/private/Repair/Collation.php 0% <0%> (ø) 16% <0%> (ø) ⬇️
apps/dav/lib/CalDAV/Activity/Provider/Calendar.php 0% <0%> (ø) 43% <0%> (ø) ⬇️
apps/files_external/lib/AppInfo/Application.php
...xternal/lib/Lib/Auth/Password/LoginCredentials.php
apps/files_external/lib/Command/Export.php
... and 136 more

@rullzer rullzer merged commit 323dc4a into stable12 Jan 9, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@rullzer rullzer deleted the 12-7570 branch Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment