New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Keep all shipped apps enabled because they should be okay #7888

Merged
merged 1 commit into from Jan 16, 2018

Conversation

Projects
None yet
3 participants
@nickvergessen
Member

nickvergessen commented Jan 16, 2018

Backport #7879

Keep all shipped apps enabled because they should be okay
Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Jan 16, 2018

Is it okay to put this into 12.0.5 maybe?

@rullzer

This comment has been minimized.

Member

rullzer commented Jan 16, 2018

@MorrisJobke fine by me

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Jan 16, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 16, 2018

Codecov Report

Merging #7888 into stable12 will increase coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #7888      +/-   ##
==============================================
+ Coverage       53.84%   53.84%   +<.01%     
  Complexity      22758    22758              
==============================================
  Files            1385     1385              
  Lines           87148    87147       -1     
  Branches         1331     1331              
==============================================
  Hits            46926    46926              
+ Misses          40222    40221       -1
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/app.php 52.8% <0%> (+0.1%) 219 <0> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
lib/private/Server.php 84.68% <0%> (-0.13%) 121% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️
lib/private/Security/CertificateManager.php 92.07% <0%> (+0.99%) 39% <0%> (ø) ⬇️

@rullzer rullzer merged commit 60fa75d into stable12 Jan 16, 2018

2 of 3 checks passed

codecov/patch 0% of diff hit (target 53.84%)
Details
codecov/project 53.84% (+<.01%) compared to a3059d0
Details
continuous-integration/drone/pr the build was successful
Details

@rullzer rullzer deleted the backport/7879/dont-disable-shipped-apps-on-errors-12 branch Jan 16, 2018

@MorrisJobke MorrisJobke referenced this pull request Jan 18, 2018

Merged

12.0.5 RC2 #7937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment