New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Dont polute the log on DAV emaillogin #8045

Merged
merged 2 commits into from Feb 6, 2018

Conversation

Projects
None yet
4 participants
@rullzer
Member

rullzer commented Jan 25, 2018

Backport of #8002

rullzer added some commits Jan 23, 2018

Don't polute log when loggin into dav with email
* We first try the email as username but this fails
* Then we get the uid from the email and try again

We should not log the first attempt since it polutes the log with failed
login attempts while the login actually is valid.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov

This comment has been minimized.

codecov bot commented Jan 25, 2018

Codecov Report

Merging #8045 into stable13 will increase coverage by 0.16%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             stable13   #8045      +/-   ##
=============================================
+ Coverage       51.23%   51.4%   +0.16%     
+ Complexity      24981   24979       -2     
=============================================
  Files            1607    1599       -8     
  Lines           95049   94727     -322     
  Branches         1376    1376              
=============================================
- Hits            48696   48691       -5     
+ Misses          46353   46036     -317
Impacted Files Coverage Δ Complexity Δ
lib/versioncheck.php
...s/user_ldap/lib/Controller/ConfigAPIController.php
apps/dav/lib/Migration/CalDAVRemoveEmptyValue.php
apps/user_ldap/lib/Wizard.php
...files_trashbin/composer/composer/autoload_psr4.php
apps/dav/lib/CardDAV/ContactsManager.php
apps/files_versions/composer/autoload.php
...pps/encryption/composer/composer/autoload_real.php
apps/dav/lib/CalDAV/CalDavBackend.php
.../private/App/AppStore/Bundles/EnterpriseBundle.php
... and 3194 more
@MorrisJobke

Tested and works 👍

@rullzer

This comment has been minimized.

Member

rullzer commented Feb 6, 2018

Review time! we can merge 13.0.1 stuff!

@rullzer rullzer merged commit b55b1b5 into stable13 Feb 6, 2018

3 checks passed

codecov/patch Coverage not affected when comparing e79a755...2bed7a7
Details
codecov/project 51.4% (+0.16%) compared to e79a755
Details
continuous-integration/drone/pr the build was successful
Details

@rullzer rullzer deleted the 8002_13 branch Feb 6, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment