New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12] Use S3Client::upload instead of splitting single/multipart upload ourselves #8101

Merged
merged 1 commit into from Feb 8, 2018

Conversation

Projects
None yet
3 participants
@icewind1991
Member

icewind1991 commented Jan 29, 2018

Backport of #8033

Use S3Client::upload instead of splitting single/multipart upload our…
…selves

Signed-off-by: Robin Appelman <robin@icewind.nl>

@icewind1991 icewind1991 added this to the Nextcloud 12.0.6 milestone Jan 29, 2018

@icewind1991 icewind1991 requested review from rullzer and MorrisJobke Jan 29, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 29, 2018

Codecov Report

Merging #8101 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #8101      +/-   ##
==============================================
+ Coverage       53.84%   53.85%   +<.01%     
+ Complexity      22761    22753       -8     
==============================================
  Files            1385     1385              
  Lines           87150    87121      -29     
  Branches         1331     1331              
==============================================
- Hits            46926    46915      -11     
+ Misses          40224    40206      -18
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/ObjectStore/S3ObjectTrait.php 75% <100%> (+17.1%) 5 <0> (-8) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️
@rullzer

🐘

@MorrisJobke

MorrisJobke approved these changes Feb 8, 2018 edited

@MorrisJobke MorrisJobke merged commit 08a13dd into stable12 Feb 8, 2018

3 checks passed

codecov/patch 100% of diff hit (target 53.84%)
Details
codecov/project 53.85% (+<.01%) compared to 9eddb01
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the s3-uploader-12 branch Feb 8, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

12.0.6 RC 1 #8750

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment